[18.0][FIX] web_responsive: Fix menu icon rendering by delegating to Odoo's built-in functionality#3433
Open
mohamedhagag wants to merge 4 commits intoOCA:18.0from
Open
[18.0][FIX] web_responsive: Fix menu icon rendering by delegating to Odoo's built-in functionality#3433mohamedhagag wants to merge 4 commits intoOCA:18.0from
mohamedhagag wants to merge 4 commits intoOCA:18.0from
Conversation
The previous implementation failed to render menu icons when only base64 image data was present without a file on disk. This happened because the logic checked for `menu.webIcon` but ignored `menu.webIconData` when webIcon was missing. The fix simplifies the logic by delegating icon handling to Odoo's built-in webIconData, which already properly handles all icon formats: - Base64 encoded images (PNG and SVG) - File paths (module,filename format) - Direct data URIs This approach follows the pattern used by muk_web_appsbar and trusts Odoo's menu service to provide correctly formatted icon data. Co-authored-by: mohamedhagag <1042088+mohamedhagag@users.noreply.github.com>
Add more detailed JSDoc comment for updateMenuWebIconData to clarify the function's purpose and how it works with the menu copy pattern. Co-authored-by: mohamedhagag <1042088+mohamedhagag@users.noreply.github.com>
Fix menu icon rendering for base64-only images
Contributor
mohamedhagag
changed the title
mohamedhagag
changed the title
mohamedhagag
changed the title
Member
|
ping @DorianMAG , seems to fix one of our issues |
DorianMAG
suggested changes
Feb 24, 2026
DorianMAG
left a comment
DorianMAG
left a comment
There was a problem hiding this comment.
Hi @mohamedhagag,
Thx for this FIX.
LGTM, but can you squash commit plz and push force plz?
One commit by PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation failed to render menu icons when only base64
image data was present without a file on disk. This happened because the
logic checked for
menu.webIconbut ignoredmenu.webIconDatawhenwebIcon was missing.
The fix simplifies the logic by delegating icon handling to Odoo's
built-in webIconData, which already properly handles all icon formats:
This approach follows the standards and trusts
Odoo's menu service to provide correctly formatted icon data.