[18.0][ADD] web_chat_separate_group#3442
Conversation
|
@Hugo-Trentesaux Can you rename the commits for the usual codenames in OCA? in this case, only one commit with [ADD] web_chat_separate_group. Can you check the tests and pre-commit please too For pre-commit you can make pre-commit install locally and pre-commit run -a to review the errors (and they will be checked anytime you try to make a commit) |
Isn't there a "squash" option on github too? On gitlab this allows to have a single commit with the name of the merge request when merging. I'll do.
I did. And the failing tests seem to be in other modules, do I need to fix them to? Seems more suited to an other PR. |
|
/ocabot rebase |
|
Congratulations, PR rebased to 18.0. |
|
pre-commit error comes from the fact of using a .js file directly, you should use esm.js /home/runner/work/web/web/web_chat_separate_group/static/src/discuss_patch.js |
|
Tests were fixed with rebase. Please squash the commits in a single one and fix pre-commit with my comments (you can check locally by using |
Separates group chat and direct message in mail left panel.