Skip to content

[18.0][ADD] web_chat_separate_group#3442

Open
Hugo-Trentesaux wants to merge 6 commits intoOCA:18.0from
Hugo-Trentesaux:18.0
Open

[18.0][ADD] web_chat_separate_group#3442
Hugo-Trentesaux wants to merge 6 commits intoOCA:18.0from
Hugo-Trentesaux:18.0

Conversation

@Hugo-Trentesaux
Copy link

@Hugo-Trentesaux Hugo-Trentesaux commented Feb 19, 2026

Separates group chat and direct message in mail left panel.

@etobella
Copy link
Member

etobella commented Mar 6, 2026

@Hugo-Trentesaux Can you rename the commits for the usual codenames in OCA? in this case, only one commit with [ADD] web_chat_separate_group. Can you check the tests and pre-commit please too

For pre-commit you can make pre-commit install locally and pre-commit run -a to review the errors (and they will be checked anytime you try to make a commit)

@Hugo-Trentesaux
Copy link
Author

only one commit with [ADD] web_chat_separate_group

Isn't there a "squash" option on github too? On gitlab this allows to have a single commit with the name of the merge request when merging. I'll do.

Can you check the tests and pre-commit please too

I did. And the failing tests seem to be in other modules, do I need to fix them to? Seems more suited to an other PR.

@etobella
Copy link
Member

etobella commented Mar 9, 2026

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 18.0.

@etobella
Copy link
Member

etobella commented Mar 9, 2026

pre-commit error comes from the fact of using a .js file directly, you should use esm.js

/home/runner/work/web/web/web_chat_separate_group/static/src/discuss_patch.js
1:1 error Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

@etobella
Copy link
Member

etobella commented Mar 9, 2026

Tests were fixed with rebase. Please squash the commits in a single one and fix pre-commit with my comments (you can check locally by using pre-commit run -a )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants