Skip to content

[19.0][MIG] web_pwa_customize: Migration to 19.0#3454

Open
AnmollGarg wants to merge 7 commits intoOCA:19.0from
AnmollGarg:19.0-mig-web_pwa_customize
Open

[19.0][MIG] web_pwa_customize: Migration to 19.0#3454
AnmollGarg wants to merge 7 commits intoOCA:19.0from
AnmollGarg:19.0-mig-web_pwa_customize

Conversation

@AnmollGarg
Copy link

@AnmollGarg AnmollGarg commented Feb 26, 2026

Migration of web_pwa_customize to 19.0

  1. Preserved history from 18.0 using the technical migration method (merge -s ours).
  2. Updated manifest for 19.0 compatibility.
  3. Fixed lazy translation issues.

CC @pedrobaeza

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

Please check as well the CI.

@AnmollGarg AnmollGarg force-pushed the 19.0-mig-web_pwa_customize branch 3 times, most recently from 725636e to 13b5fb2 Compare February 26, 2026 10:00
@pedrobaeza
Copy link
Member

/ocabot migration web_pwa_customize

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Feb 26, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 26, 2026
44 tasks
@AnmollGarg AnmollGarg force-pushed the 19.0-mig-web_pwa_customize branch from 13b5fb2 to 23deac4 Compare March 4, 2026 06:27
@AnmollGarg
Copy link
Author

@pedrobaeza Could you please review it again when you have a moment? Thanks!

@pedrobaeza
Copy link
Member

2019 commits is for sure not correct...

@AnmollGarg AnmollGarg force-pushed the 19.0-mig-web_pwa_customize branch from df0165a to 073d33d Compare March 5, 2026 11:08
@AnmollGarg
Copy link
Author

@pedrobaeza

Thanks for the feedback.
The branch history has been cleaned and the PR now contains a single migration commit. Please let me know if anything else needs adjustment.

@pedrobaeza
Copy link
Member

Well, it's not one extreme or the other. Please just follow the migration guide.

@AnmollGarg AnmollGarg force-pushed the 19.0-mig-web_pwa_customize branch from 073d33d to a7f582e Compare March 5, 2026 13:03
@AnmollGarg
Copy link
Author

@pedrobaeza Good morning! I have reworked the branch and strictly followed the technical migration method to preserve the 18.0 commit history. The branch now correctly contains the historical commits, followed by the pre-commit auto-fixes, and the 19.0 migration/fix commits.

The CI checks are also fully green now. Could you please review it again when you have a moment? Thanks for your patience and guidance!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts. This sounds better. Just take the inline comment, and please squash the latest 3 commits together (those corresponding to the migration itself, except pre-commit auto-fixes)

@AnmollGarg AnmollGarg force-pushed the 19.0-mig-web_pwa_customize branch from 7cded1b to 6e20de2 Compare March 6, 2026 09:36
@AnmollGarg
Copy link
Author

Thanks for the efforts. This sounds better. Just take the inline comment, and please squash the latest 3 commits together (those corresponding to the migration itself, except pre-commit auto-fixes)

@pedrobaeza Done! The empty lines in the test methods have been removed, and the final changes are now squashed into a single [MIG] commit. The CI checks are fully green.

Thanks again!

@AnmollGarg
Copy link
Author

Thanks!!

@AnmollGarg
Copy link
Author

@pedrobaeza Thanks for the approval! Is there anything else pending on my side, or is this ready to be merged?

@pedrobaeza
Copy link
Member

Check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review. 2 reviews are needed. You can review other PRs, and ask in exchange that they review yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants