[19.0][MIG] web_pwa_customize: Migration to 19.0#3454
[19.0][MIG] web_pwa_customize: Migration to 19.0#3454AnmollGarg wants to merge 7 commits intoOCA:19.0from
Conversation
|
Thanks for the contribution. Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0. If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance. Please check as well the CI. |
725636e to
13b5fb2
Compare
|
/ocabot migration web_pwa_customize |
13b5fb2 to
23deac4
Compare
|
@pedrobaeza Could you please review it again when you have a moment? Thanks! |
|
2019 commits is for sure not correct... |
df0165a to
073d33d
Compare
|
Thanks for the feedback. |
|
Well, it's not one extreme or the other. Please just follow the migration guide. |
073d33d to
a7f582e
Compare
|
@pedrobaeza Good morning! I have reworked the branch and strictly followed the technical migration method to preserve the 18.0 commit history. The branch now correctly contains the historical commits, followed by the pre-commit auto-fixes, and the 19.0 migration/fix commits. The CI checks are also fully green now. Could you please review it again when you have a moment? Thanks for your patience and guidance! |
pedrobaeza
left a comment
There was a problem hiding this comment.
Thanks for the efforts. This sounds better. Just take the inline comment, and please squash the latest 3 commits together (those corresponding to the migration itself, except pre-commit auto-fixes)
7cded1b to
6e20de2
Compare
@pedrobaeza Done! The empty lines in the test methods have been removed, and the final changes are now squashed into a single [MIG] commit. The CI checks are fully green. Thanks again! |
|
Thanks!! |
|
@pedrobaeza Thanks for the approval! Is there anything else pending on my side, or is this ready to be merged? |
|
Check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review. 2 reviews are needed. You can review other PRs, and ask in exchange that they review yours. |
Migration of web_pwa_customize to 19.0
CC @pedrobaeza