Open
Conversation
Member
|
Ok that's sensible. I'm going to do a release of a dune version first, then look at this.
Anyway, I'm not sure I see why you say that removing those function might help with using the library. As any use of this using the added signature is certainly not going to be using unsafe-string. Also I would prefer explicit names rather than single letters. |
Author
|
I changed to the explicit names. The Let me know if there are other improvements that could make it into this MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an abstract interface for the
Endian*modules. The intent is to allow the use of the endian library as a functor argument. I.e., making the following code valid:Points to discuss:
EndianStringmodules have deprecated writing functions (they are deprecated in favour ofEndianBytes). Should these deprecated functions be removed? I think they should, let me know if you agree/disagree.EndianStringand (2) exposing types in all of theEndian{Bigstring,Bytes,String}.{Big,Little}Endian{,_unsafe}.EndianSig.GET(resp EndianSig.SET) intoEndianSig.R(respEndianSig.W) and offer aEndianSig.RW` in addition? I'll make an additional commit towards this and we can discuss it there.