Skip to content

TEDEFO 4766 dynamic rules#2

Merged
bertrand-lorentz merged 17 commits intodevelopfrom
TEDEFO-4776-dynamic-rules
Mar 23, 2026
Merged

TEDEFO 4766 dynamic rules#2
bertrand-lorentz merged 17 commits intodevelopfrom
TEDEFO-4776-dynamic-rules

Conversation

@rousso
Copy link
Contributor

@rousso rousso commented Mar 20, 2026

No description provided.

@rousso rousso requested a review from bertrand-lorentz March 20, 2026 14:48
@bertrand-lorentz bertrand-lorentz changed the title TEDEFO 4776 dynamic rules TEDEFO 4766 dynamic rules Mar 23, 2026
Copy link
Contributor

@bertrand-lorentz bertrand-lorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See various comments.
The main issue is that the unit tests fail, probably due to a missing file.
I would recommend creating a GitHub workflow to run unit tests automatically.

Please also note that this PR has commits that are already merged in develop.

@rousso rousso requested a review from bertrand-lorentz March 23, 2026 09:48
@bertrand-lorentz
Copy link
Contributor

Unit tests now fail with a different error, see below.
This seems to indicate that unit tests require external files, which is problematic.

[INFO] Running eu.europa.ted.efx.cli.ValidateCommandTest
[ERROR] Tests run: 10, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 3.977 s <<< FAILURE! -- in eu.europa.ted.efx.cli.ValidateCommandTest
[ERROR] eu.europa.ted.efx.cli.ValidateCommandTest.testFullPipeline(String, String, int, int, String, String)[1] -- Time elapsed: 1.291 s <<< FAILURE!
org.opentest4j.AssertionFailedError:
Expected assert id 'R-TST-001' in output: Validating notice: src\test\resources\eu\europa\ted\efx\cli\test-cn-notice.xml
Mode: schxslt
WARN SDK download failed (No artifacts found for SDK 2.0.0-SNAPSHOT.), assuming SDK is already available on disk.
ERROR Validation failed: Resource [C:\Users\lorenbe\Sources\efx-cli\eforms-sdk\2.0.0-SNAPSHOT\fields\fields.json] does not exist
==> expected: but was:
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
at eu.europa.ted.efx.cli.ValidateCommandTest.testFullPipeline(ValidateCommandTest.java:157)

@rousso
Copy link
Contributor Author

rousso commented Mar 23, 2026

Unit tests now fail with a different error, see below. This seems to indicate that unit tests require external files, which is problematic.

[INFO] Running eu.europa.ted.efx.cli.ValidateCommandTest [ERROR] Tests run: 10, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 3.977 s <<< FAILURE! -- in eu.europa.ted.efx.cli.ValidateCommandTest [ERROR] eu.europa.ted.efx.cli.ValidateCommandTest.testFullPipeline(String, String, int, int, String, String)[1] -- Time elapsed: 1.291 s <<< FAILURE! org.opentest4j.AssertionFailedError: Expected assert id 'R-TST-001' in output: Validating notice: src\test\resources\eu\europa\ted\efx\cli\test-cn-notice.xml Mode: schxslt WARN SDK download failed (No artifacts found for SDK 2.0.0-SNAPSHOT.), assuming SDK is already available on disk. ERROR Validation failed: Resource [C:\Users\lorenbe\Sources\efx-cli\eforms-sdk\2.0.0-SNAPSHOT\fields\fields.json] does not exist ==> expected: but was: at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151) at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132) at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214) at eu.europa.ted.efx.cli.ValidateCommandTest.testFullPipeline(ValidateCommandTest.java:157)

I enabled snapshot downloads. The test now passes.

Copy link
Contributor

@bertrand-lorentz bertrand-lorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests now pass.

@bertrand-lorentz bertrand-lorentz merged commit bfc434e into develop Mar 23, 2026
@bertrand-lorentz bertrand-lorentz deleted the TEDEFO-4776-dynamic-rules branch March 23, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants