refactor(cli): consolidate skill architecture v0.2.0#11205
Draft
originalix wants to merge 15 commits intoxfrom
Draft
refactor(cli): consolidate skill architecture v0.2.0#11205originalix wants to merge 15 commits intoxfrom
originalix wants to merge 15 commits intoxfrom
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
Summary
Dimension Scores
Stats
|
- Remove all perps/Hyperliquid/leverage rules (CLI has no perps support) - Consolidate cross-domain fallback rules into common.md - Deduplicate Fast Patterns across 4 skills (each keeps domain-core only) - Align versions to 0.2.0 (marketplace, plugin, skills) - Exclude skills/ from npm files (distributed via marketplace git-subdir) - Net reduction: 310 → 204 skill lines (-34%)
2447845 to
b1c35c7
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
sidmorizon
reviewed
Apr 15, 2026
Contributor
There was a problem hiding this comment.
skill 统一用 onekey-cli- 开头吧,这样非 claude 可以安装,防止和其他用户自有 skill 命名冲突
Collaborator
Author
There was a problem hiding this comment.
好,拆完仓库后加一下前缀,这个 PR 就不合并了
Contributor
There was a problem hiding this comment.
skill 仓库和主仓库放在一起,如果用 plugin 方式安装,会把整个主仓库 pull 下来吗
Collaborator
Author
There was a problem hiding this comment.
确实有这个问题,虽然用 git-subdir 指定了路径,但是会先 clone
拆到独立的仓库里吧
auto-merge was automatically disabled
April 15, 2026 03:34
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Universal Fallbackin common.md as structuredCross-Domain Fallbacksection that absorbs rules previously scattered across all 4 skillsIntent & Context
The 4 CLI skills (market, security, swap, wallet) had grown organically through eval iterations, resulting in ~50% of each skill being instructions about OTHER skills' domains. The same Fast Patterns (address poisoning, insufficient balance, research-to-trade) appeared verbatim in 3-4 files. Perps/Hyperliquid rules were spread across all skills despite the CLI having no perps capability. This made behavioral changes require syncing across 5 files.
Design Decisions
../_shared/relative paths or git symlinks, but research confirmed the official Claude Code plugin pattern is self-contained skills with per-skillreferences/copies. Thesync-refs.sh+prebuildapproach is the sanctioned pattern used by all official multi-skill plugins (superpowers, plugin-dev).git-subdirsource, so skills must be in the repo. npm package only needsdist/andbin/.Changes Detail
_shared/common.md: Remove perps rules, rewrite Universal Fallback → Cross-Domain Fallback with consolidated trade handoff, compound intent, and research-to-trade rulesmarket/SKILL.md: 63→36 lines. Keep only price/trending/research domain rules and core patternssecurity/SKILL.md: 55→29 lines. Keep only audit/simulate domain rules and core patternsswap/SKILL.md: 66→36 lines. Keep only swap/bridge/buy/sell domain rules and core patternswallet/SKILL.md: 65→40 lines. Keep only balance/transfer/import domain rules and core patternsmarketplace.json+plugin.json: Version 0.1.0 → 0.2.0package.json: Removeskills/from npmfilesarrayRisk Assessment
Test plan
npm packin apps/cli excludes skills directory