Skip to content

fix(market): correct market portfolio width in iPad split view | OK-48237#11214

Merged
originalix merged 2 commits intoOneKeyHQ:xfrom
zy2000-star:codex/fix-market-ipad-portfolio-split
Apr 15, 2026
Merged

fix(market): correct market portfolio width in iPad split view | OK-48237#11214
originalix merged 2 commits intoOneKeyHQ:xfrom
zy2000-star:codex/fix-market-ipad-portfolio-split

Conversation

@zy2000-star
Copy link
Copy Markdown
Contributor

@zy2000-star zy2000-star commented Apr 14, 2026

Summary

  • fix the Market detail portfolio area being clipped in iPad split view
  • pass the split-view tab container width into MobileInformationTabs
  • keep the TradingView height logic unchanged
  • align the Market detail tabs behavior with other native split-view tab layouts in the app

Root Cause

MobileInformationTabs did not pass the actual split-view width to Tabs.Container, so the portfolio tab could render with an incorrect width and appear to show only the left half in iPad half-screen mode.

In the iPad split-view scenario, the page itself is displayed in a constrained subview, but the tabs container was still falling back to an unresolved/default width path. That mismatch caused the portfolio content to lay out as if it had more horizontal space than the visible pane actually provided, which led to the right side being clipped.

Changes

  • use useTabContainerWidth() in MobileInformationTabs
  • pass the resolved width to Tabs.Container on native
  • make the portfolio tab layout follow the actual split-view container width instead of relying on implicit sizing
  • keep the change scoped to the Market detail information tabs layer only
  • do not include the earlier TradingView height adjustment

Impact

  • the portfolio section in Market detail should render within the visible iPad split-view pane
  • portfolio rows and sticky header columns should stay aligned with the actual available width
  • no behavior change is intended for non-native environments
  • no visual change is intended for normal full-width mobile layouts

Scope

This change only affects the Market detail mobile information tabs layout and does not modify:

  • TradingView/chart height behavior
  • portfolio data fetching or tab composition
  • desktop Market detail layout
  • unrelated local workspace changes

Open with Devin

@revan-zhang
Copy link
Copy Markdown
Contributor

revan-zhang commented Apr 14, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@zy2000-star zy2000-star enabled auto-merge (squash) April 14, 2026 14:23
@originalix originalix disabled auto-merge April 15, 2026 00:32
@originalix originalix merged commit 0fc1d53 into OneKeyHQ:x Apr 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants