Skip to content

analytics: Check ext.eids alongside eids for optable resolved events in `auctionEnd#271

Merged
mosherBT merged 3 commits intomasterfrom
analytics/check-ext-eids-for-eids
Apr 23, 2026
Merged

analytics: Check ext.eids alongside eids for optable resolved events in `auctionEnd#271
mosherBT merged 3 commits intomasterfrom
analytics/check-ext-eids-for-eids

Conversation

@mosherBT
Copy link
Copy Markdown
Contributor

@mosherBT mosherBT commented Apr 22, 2026 •
edited
Loading

Screenshot 2026-04-22 at 4 55 01 PM Seeing optable EIDs in this path which is not going to analytics attribution because we do not look there

@mosherBT mosherBT self-assigned this Apr 22, 2026
@mosherBT mosherBT force-pushed the analytics/check-ext-eids-for-eids branch from a12d558 to cac4fa8 Compare April 22, 2026 21:05
@mosherBT mosherBT force-pushed the analytics/check-ext-eids-for-eids branch from 0f04fd2 to 0b6dedf Compare April 23, 2026 13:33
jplaroche
jplaroche approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jplaroche jplaroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosherBT mosherBT merged commit 210bd41 into master Apr 23, 2026
7 checks passed
@mosherBT mosherBT deleted the analytics/check-ext-eids-for-eids branch April 23, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jplaroche jplaroche jplaroche approved these changes

Assignees

@mosherBT mosherBT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mosherBT @jplaroche