Port Trader Changes from PoB 2 #8386
Draft
QuickStick123 wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
Draft
Port Trader Changes from PoB 2 #8386QuickStick123 wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
QuickStick123 wants to merge 3 commits intoPathOfBuildingCommunity:devfrom
Conversation
Fix duplicated code causing item bases to be parsed twice and once with old code leaking talismans into general code. Fix negative modifers Handle sign after the fact and try fixing a mod that wasn't being parsed correctly. Fix failed parse for a line affecting others. Properly Fixed Several fixes including talismans handling change, fix incorrect invert implementation and invert negaed mods before item creation, fix multi line implicits and move passives back to correct spot. Fix chance to block flat again. Change up and fix a couple of the local mods.
|
Does this branch work correctly for Path of Exile 2, allowing characters to be imported? |
Contributor
Author
|
No these changes are for PoE 1 version of the client I just ported the improvements I made back to the PoE 1 side, afaik there is no way to import characters currently for poe 2 even in our dev environment due to lacking apis. |
2 tasks
Contributor
Author
|
This has an issue regarding parsing of mods that don't match with signage on trade mods. It is a fairly noticeable problem for the poe 2 client but probably won't cause to many problems here but I will mark it as a draft anyways. |
Contributor
|
Does FetchLeagues support getting the user's private leagues? If so, may I suggest breaking out the query fixes into their own PR so we can benefit from them, while you figure out your mod issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This refactors how inverted mods are handled, and does away with saving the sign value and subType. This means there is a new section called Talismans.
Implicits has been refactored and now uses ProcessMod this stops them applying to stuff they shouldn't and don't spam the QueryMods with subType stuff.
Several negative value mods now work correctly and some mods that might've been parsed correctly on an item should work for weight generation.
POSESSID is automatically expired.
HTML passed queries were removed in favor of API due to receiving constant 403 from them. This means realmIds and names were hardcoded but this shouldn't be an issue as they are infrequently updated.
Generation no longer uses invert and instead negative values are parsed in the stat weight which is handled by building values in queryMods.
The sign appearing might not be the most correct since it assumes that if a mod appears on the trade site with a + it will have one but there are cases where this isn't the case this can be seen in PoE 2 quite commonly but probably isn't a big deal here. Ideally using their stat descriptions would be ideal to determine this.