Add functionality for multiple notes#9456
Add functionality for multiple notes#9456michelrtm wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Conversation
|
As far as I could tell this could be a drop-in implementation in POB for POE2 as well. |
|
Seems like a lot of note space is wasted by the new list box. Might be better if it was next to the colour buttons, and a lot shorter? |
|
This looks pretty neat and I like it from a user perspective, but iirc there was some hesitation with expanding the notes section functionality in the past because it can already kinda bloat the exports, which puts additional strain on the hosting providers. Did you also implement a limit for the number of additional notes sections a user can create? |
|
@majochem thanks for the positive feedback. I understand the concerns here but wasn't aware of the hesitations. Currently there's no limit to the number of notes to create but I'm assuming (maybe wrongly) that if the users can create multiple set of notes then they can split the bigger notes into smaller sections and this will only consume some additional characters in the XML for similar amounts of actual text in favor of improved UI/UX. |

Fixes #8948 .
Description of the problem being solved:
The original ticket was requesting the ability to have multiple notes both for POE 1 and 2. I have had a look at the codebase and had a stab at implementing this feature request.
Instead of 1 global notes section, this PR introduces the ability to have multiple notes for a build and allows you to create, delete, reorder and set which note is active for the build, keeping the formatting of the editor.
Steps taken to verify a working solution:
Defaultnote, saved, exited and reopened the build to verify that the changes were savedLink to a build that showcases this PR:
https://maxroll.gg/poe/pob/a13ev0o0
Before screenshot:
After screenshot:
This is the new XML structure when the build is saved: