Skip to content

Fix ParameterDescription of exclusive bounds#339

Open
christophfroehlich wants to merge 5 commits intomainfrom
fix/description/exclusive-bounds
Open

Fix ParameterDescription of exclusive bounds#339
christophfroehlich wants to merge 5 commits intomainfrom
fix/description/exclusive-bounds

Conversation

@christophfroehlich
Copy link
Copy Markdown
Collaborator

Fixes #256

@christophfroehlich christophfroehlich added the backport-humble Triggers PR backport to ROS 2 humble. label Apr 7, 2026
Base automatically changed from fix/conflicting-validators to main April 8, 2026 11:46
@christophfroehlich christophfroehlich force-pushed the fix/description/exclusive-bounds branch from caaaa4a to 6b96a63 Compare April 8, 2026 11:48
@christophfroehlich christophfroehlich marked this pull request as ready for review April 8, 2026 11:48
Copy link
Copy Markdown
Contributor

@ottojo ottojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like it will fix the issue i reported! (Haven't built and tested it so far, myself i can do that next week).
I remember when looking into it before i came across std::nextafter, but i'm not sure if that is any different, the +/- epsilon is definetly more readable 👍

@christophfroehlich
Copy link
Copy Markdown
Collaborator Author

christophfroehlich commented Apr 17, 2026

Oh, std::nextafter seems to be a nice method. I haven't thought too much about floating point precision. Is anynumber+eps always greater than the floating point representation of anynumber? maybe not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gt<> validator sets incorrect from_value in parameter descriptor

2 participants