Skip to content

CTargetReticles 99%#52

Merged
encounter merged 5 commits intomainfrom
targetreticles
Mar 27, 2026
Merged

CTargetReticles 99%#52
encounter merged 5 commits intomainfrom
targetreticles

Conversation

@encounter
Copy link
Copy Markdown
Member

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Mar 27, 2026

Report for GM8E01_48 (7a37b02 - c4c9595)

No changes

Report for GM8E01_01 (7a37b02 - c4c9595)

📈 Matched code: 34.32% (+0.24%, +9712 bytes)
📈 Matched data: 13.58% (+0.00%, +36 bytes)

✅ 30 new matches
Unit Item Bytes Before After
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CCompoundTargetReticle(const CStateManager&) +1852 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateCurrLockOnGroup(float, const CStateManager&) +1768 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateNextLockOnGroup(float, const CStateManager&) +876 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::Update(float, const CStateManager&) +824 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::Draw(const CStateManager&) const +784 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculateClampedScale(CVector3f, float, float, float, const CStateManager&) +416 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::Touch() const +364 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculateOrbitZoneReticlePosition(const CStateManager&, bool) const +344 0.00% 100.00%
main/MetroidPrime/CTargetReticles rstl::vector<CCompoundTargetReticle::SOuterItemInfo, rstl::rmemory_allocator>::reserve(int) +300 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateOrbitZoneGroup(float, const CStateManager&) +292 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetReticleRenderState::InterpolateWithClamp(const CTargetReticleRenderState&, CTargetReticleRenderState&, const CTargetReticleRenderState&, float) +288 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateTargetParameters(CTargetReticleRenderState&, const CStateManager&) +280 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::COrbitPointMarker() +204 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculatePositionWorld(const CActor&, const CStateManager&) const +148 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::SOuterItemInfo::SOuterItemInfo(const char*) +124 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::CheckLoadComplete() +116 0.00% 100.00%
main/MetroidPrime/CTargetReticles __sinit_CTargetReticles_cpp +104 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::GetDesiredReticleState(const CStateManager&) const +92 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::CheckLoadComplete() +88 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::Update(float, const CStateManager&) +84 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::IsGrappleTarget(TUniqueId, const CStateManager&) +76 0.00% 100.00%
main/MetroidPrime/CTargetReticles offshoot_func(float, float, float) +72 0.00% 100.00%
main/MetroidPrime/CTargetReticles calculate_premultiplied_overshoot_offset(float) +60 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::CTargetingManager(const CStateManager&) +56 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetReticleRenderState::CTargetReticleRenderState(TUniqueId, float, CVector3f, float, float, bool) +52 0.00% 100.00%
main/MetroidPrime/CTargetReticles .bss +32 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::Touch() const +32 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CheckLoadComplete() +8 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::ResetInterpolationTimer(float) +8 0.00% 100.00%
main/MetroidPrime/CTargetReticles .ctors +4 0.00% 100.00%
📈 9 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::DrawCurrLockOnGroup(const CMatrix3f&, const CStateManager&) const +5594 0.00% 99.47%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::DrawNextLockOnGroup(const CMatrix3f&, const CStateManager&) const +2625 0.00% 99.29%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::Update(float, const CStateManager&) +2542 0.00% 99.95%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculateRadiusWorld(const CActor&, const CStateManager&) const +522 0.00% 99.02%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::DrawOrbitZoneGroup(const CMatrix3f&, const CStateManager&) const +362 0.00% 99.67%
main/MetroidPrime/CTargetReticles .rodata +301 0.00% 99.34%
main/MetroidPrime/CTargetReticles .sdata2 +144 0.00% 95.00%
main/MetroidPrime/CTargetReticles .sdata +52 0.00% 73.47%
main/MetroidPrime/Player/CPlayer CPlayer::Render(const CStateManager&) const +44 90.41% 92.84%

Report for GM8E01_00 (7a37b02 - c4c9595)

📈 Matched code: 35.63% (+0.28%, +11032 bytes)
📈 Matched data: 32.05% (+0.02%, +340 bytes)

✅ 35 new matches
Unit Item Bytes Before After
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CCompoundTargetReticle(const CStateManager&) +1852 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateCurrLockOnGroup(float, const CStateManager&) +1768 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateNextLockOnGroup(float, const CStateManager&) +876 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::Update(float, const CStateManager&) +824 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::Draw(const CStateManager&) const +784 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::DrawGrappleGroup(const CMatrix3f&, const CStateManager&, bool) const +600 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculateClampedScale(CVector3f, float, float, float, const CStateManager&) +416 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::Draw(const CStateManager&, bool) const +408 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::Touch() const +364 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculateOrbitZoneReticlePosition(const CStateManager&, bool) const +344 0.00% 100.00%
main/MetroidPrime/CTargetReticles .rodata +304 0.00% 100.00%
main/MetroidPrime/CTargetReticles rstl::vector<CCompoundTargetReticle::SOuterItemInfo, rstl::rmemory_allocator>::reserve(int) +300 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateOrbitZoneGroup(float, const CStateManager&) +292 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetReticleRenderState::InterpolateWithClamp(const CTargetReticleRenderState&, CTargetReticleRenderState&, const CTargetReticleRenderState&, float) +288 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::UpdateTargetParameters(CTargetReticleRenderState&, const CStateManager&) +280 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::Draw(const CStateManager&, bool) const +268 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::COrbitPointMarker() +204 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculatePositionWorld(const CActor&, const CStateManager&) const +148 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::SOuterItemInfo::SOuterItemInfo(const char*) +124 0.00% 100.00%
main/MetroidPrime/CTargetReticles COrbitPointMarker::CheckLoadComplete() +116 0.00% 100.00%
main/MetroidPrime/CTargetReticles __sinit_CTargetReticles_cpp +104 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::GetDesiredReticleState(const CStateManager&) const +92 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::CheckLoadComplete() +88 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::Update(float, const CStateManager&) +84 0.00% 100.00%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::IsGrappleTarget(TUniqueId, const CStateManager&) +76 0.00% 100.00%
main/MetroidPrime/CTargetReticles offshoot_func(float, float, float) +72 0.00% 100.00%
main/MetroidPrime/CTargetReticles calculate_premultiplied_overshoot_offset(float) +60 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetingManager::CTargetingManager(const CStateManager&) +56 0.00% 100.00%
main/MetroidPrime/CTargetReticles CTargetReticleRenderState::CTargetReticleRenderState(TUniqueId, float, CVector3f, float, float, bool) +52 0.00% 100.00%
main/MetroidPrime/CTargetReticles IsDamageOrbit(CPlayer::EOrbitBrokenType) +44 0.00% 100.00%

...and 5 more new matches

📈 9 improvements in unmatched items
Unit Item Bytes Before After
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::DrawCurrLockOnGroup(const CMatrix3f&, const CStateManager&) const +5594 0.00% 99.47%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::DrawNextLockOnGroup(const CMatrix3f&, const CStateManager&) const +2625 0.00% 99.29%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::Update(float, const CStateManager&) +2542 0.00% 99.95%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::CalculateRadiusWorld(const CActor&, const CStateManager&) const +522 0.00% 99.02%
main/MetroidPrime/CTargetReticles CCompoundTargetReticle::DrawOrbitZoneGroup(const CMatrix3f&, const CStateManager&) const +362 0.00% 99.67%
main/MetroidPrime/CTargetReticles .sdata2 +144 0.00% 95.00%
main/MetroidPrime/Enemies/CScriptPhazonPool CScriptPhazonPool::Render(const CStateManager&) const +82 75.11% 94.42%
main/MetroidPrime/CTargetReticles .sdata +52 0.00% 73.47%
main/MetroidPrime/Player/CPlayer CPlayer::Render(const CStateManager&) const +44 90.41% 92.84%

@encounter encounter merged commit bbc96bd into main Mar 27, 2026
6 checks passed
@encounter encounter deleted the targetreticles branch March 27, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant