Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2466 +/- ##
=======================================
Coverage 99.24% 99.25%
=======================================
Files 39 41 +2
Lines 3057 3080 +23
Branches 675 671 -4
=======================================
+ Hits 3034 3057 +23
Misses 13 13
Partials 10 10 🚀 New features to boost your workflow:
|
|
@staticdev Do you think you can give this as review? |
|
Sure @DanielNoord i am on vacation but will be back in 9 days. |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
staticdev
left a comment
There was a problem hiding this comment.
@DanielNoord I would not rush for this one, actually I was thinking of finally remove support for Python 2 first, since 3.15 is pre-release still we don't need to merge this now, but we can keep it here.
|
@staticdev I think adding support for lazy imports might be quite a lot of work. See the linked issue, as we'll also need to coordinate a bit with ruff and others. Merging this will at least unblock this as we'll be able to start testing and parsing the lazy imports. I think it would be good for the community if isort supports lazy imports from day 1. |
There was a problem hiding this comment.
Fine @DanielNoord, I checked the PR and I think also can be a preliminary implementation then. Since it is updating dependencies, it needs to have a new uv.lock.
Before we can consider #2462 we first need to support 3.15 to begin with.
This:
stdlibsto the latest version to getpy315support3.15marker where needed intoxand CI filestests/integration/test_hypothesmith.pyon 3.15 aslibcstdoesn't support it (yet)djangointegration test3.15yet3.15marker to metadatapygmentsQuite a lot of changes, but all necessary to make 3.15 pass on CI in its fullest capacity.