Conversation
…is explicitly set to `None`
heevasti
requested changes
Apr 16, 2026
Collaborator
heevasti
left a comment
heevasti
left a comment
There was a problem hiding this comment.
Looks fine. But I think there should be a unit-test[s] that would notice that the method has slightly changed, giving CfgQmi object back always when None is explicitly given. And all the other options should work as before.
Thom747
changed the title
qmi.start parameter config_file is explicitly set to Noneqmi.start parameter config_file is explicitly set to None
…ans-none-config_file-argument-to-qmistart
Collaborator
Author
Added a unittest! |
…ans-none-config_file-argument-to-qmistart
heevasti
approved these changes
Apr 16, 2026
Thom747
deleted the
204-implement-none-means-none-config_file-argument-to-qmistart
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #204.