[lqcontrol] style guide review and updated maths#613
[lqcontrol] style guide review and updated maths#613matheusvillasb wants to merge 7 commits intomainfrom
Conversation
|
@matheusvillasb -- @HumphreyYang has answers to the questions you asked here #609 (comment) from #609. |
|
📖 Netlify Preview Ready! Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (53352eb) 📚 Changed Lecture Pages: lqcontrol |
|
@matheusvillasb the syntax around links wasn't formatted correctly. Checkout https://manual.quantecon.org/styleguide/doclinks.html and a99a241 |
|
📖 Netlify Preview Ready! Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (a99a241) 📚 Changed Lecture Pages: lqcontrol |
|
📖 Netlify Preview Ready! Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (cf57cac) 📚 Changed Lecture Pages: lqcontrol |
|
@matheusvillasb this lecture has quite a few style guide violations such as
Do you mind doing another pass? Note: there have been edits to this branch so you should @HumphreyYang I see there is a model in this lecture. Do you think we should use NamedTuple (in similar style to the JAX conversions)? |
Many thanks @matheusvillasb and @mmcky, Yes, I think it would be better by putting these argument into a r = 0.05
β = 1 / (1 + r)
T = 45
c_bar = 2
σ = 0.25
μ = 1
q = 1e6 |
@mmcky I'll do that! Thank you for picking these issues. |
So just to be sure, I need to do this while on my branch, right? Not on main. Also, I tried to create a new branch to edit the lecture that follows this one. When I type git status, this is what I get: PS C:\Users\mathe\QuantEcon_Lectures_Improvement\lecture-python.myst> git status no changes added to commit (use "git add" and/or "git commit -a") Is this correct? The impression I have is that the edits in lagrangian_lqdp.md were made in the branch for the lqcontrol lecture instead of the branch I created for lagrangian_lqdp. |
|
📖 Netlify Preview Ready! Preview URL: https://pr-613--sunny-cactus-210e3e.netlify.app (63f62a2) 📚 Changed Lecture Pages: lqcontrol |
-Proofread, checked all links and references
-Updated maths to style guide
-Added a few comments to solve questions I had while reading the document