Skip to content

Add requirements for testing#322

Open
amd-sriram wants to merge 2 commits intomasterfrom
add_test_requirements
Open

Add requirements for testing#322
amd-sriram wants to merge 2 commits intomasterfrom
add_test_requirements

Conversation

@amd-sriram
Copy link
Copy Markdown
Collaborator

@amd-sriram amd-sriram commented Mar 22, 2026

Motivation

The CI script additionally installs expecttest onnxscript before running the test scripts. Moved these packages to requirements_dev.txt.

Addresses comment - #303 (comment)

Test Plan

Install the packages expecttest onnxscript through requirements_dev.txt and check if these packages are installed.

pip install -r requirements_dev.txt
pip list | grep onnxscript
pip list | grep expecttest 

Test the CI.

Test Result

onnxscript                    0.5.4
expecttest                    0.3.0

Run - https://github.com/ROCm/apex/actions/runs/23505553410

Submission Checklist

Copy link
Copy Markdown
Collaborator

@jithunnair-amd jithunnair-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the line from

pip install expecttest onnxscript

@amd-sriram
Copy link
Copy Markdown
Collaborator Author

@jithunnair-amd I made the requested change and tested in the run - https://github.com/ROCm/apex/actions/runs/23505553410. Could you please review it again and merge it if it is ok. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants