Open
Conversation
jithunnair-amd
approved these changes
Mar 23, 2026
jithunnair-amd
requested changes
Mar 23, 2026
Collaborator
jithunnair-amd
left a comment
There was a problem hiding this comment.
Please also remove the line from
apex/.github/workflows/rocm-ci.yml
Line 145 in eb1f3ae
Collaborator
Author
|
@jithunnair-amd I made the requested change and tested in the run - https://github.com/ROCm/apex/actions/runs/23505553410. Could you please review it again and merge it if it is ok. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The CI script additionally installs expecttest onnxscript before running the test scripts. Moved these packages to requirements_dev.txt.
Addresses comment - #303 (comment)
Test Plan
Install the packages expecttest onnxscript through requirements_dev.txt and check if these packages are installed.
Test the CI.
Test Result
Run - https://github.com/ROCm/apex/actions/runs/23505553410
Submission Checklist