Skip to content

Fix stale and incomplete information in CLAUDE.md and README.md#110

Merged
powderluv merged 1 commit intoROCm:mainfrom
shiv-tyagi:sync-knowledge
Apr 19, 2026
Merged

Fix stale and incomplete information in CLAUDE.md and README.md#110
powderluv merged 1 commit intoROCm:mainfrom
shiv-tyagi:sync-knowledge

Conversation

@shiv-tyagi
Copy link
Copy Markdown
Member

@shiv-tyagi shiv-tyagi commented Apr 19, 2026

The knowledge files got drifted slightly due to the changes we did over last few days. This PR syncs them to current state.

Audited both files against the actual codebase and corrected:
- Document both proto files (slurm.proto + raft_internal.proto) and
  explain why Raft RPCs are kept separate from the public API surface
- Remove hardcoded "314 tests" count (actual: 876)
- Remove outdated "stub"/"post-MVP" label from spur-k8s
- List all node states (add Draining, Unknown, Suspended)
- List all job states (add Timeout, NodeFail, Preempted, Suspended)
- List all spur-core modules (was missing 9 of 15)
- Add spurrestd to SPUR_CONTROLLER_ADDR users
- Document both CLI dispatch stages (argv[0] symlink + args[1] native)

Made-with: Cursor
@shiv-tyagi shiv-tyagi requested a review from powderluv April 19, 2026 13:13
@powderluv powderluv merged commit 1a2c61d into ROCm:main Apr 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants