Using theta as the driver for VegasFlow#56
Draft
scarlehoff wants to merge 38 commits intoRiemannAI:masterfrom
Draft
Using theta as the driver for VegasFlow#56scarlehoff wants to merge 38 commits intoRiemannAI:masterfrom
scarlehoff wants to merge 38 commits intoRiemannAI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on using the RTBM as the integration driver for VegasFlow (i.e., instead of using the Vegas algorithm for sampling, using the RTBM). For that I needed several changes, some of them 100% needed (like the transformation to the sampling) although they could be if needed in the VegasFlow side.
Some are really needed inside the RTBM but are there just to facilitate the optimization (the gaussian initialization and forcing positivity through the cholesky decomposition).
The PR that implements the RTBM can be seen in: N3PDF/vegasflow#68
The main changes that this PR introduces are:
There are, however, many points that need to be improved. The main that comes to mind is the fact that the boundaries don't really mean much now as I haven't really transformed then that much.
Note: There are many changes in this PR (and not all of them useful) so I don't think this should be merge as is, but since @scarrazza is thinking on maybe having a student work on this, it's better if they have all changes available.