Conversation
Since gen_evts() is executed in separate processes for parallelisation, this needed to be done in that function, which required changes to the surrounding code.
* update hash of sample output file * remove old sample output file from tests directory * remove diff from CI (was left over from initial debugging) and set explicit exit code instead
|
Hmm … the integration test is failing under Ubuntu; the only difference I can see from the logs is in the
Not sure what's going on there; I'll look into it (but am on annual leave this afternoon, so this will need to wait until next week). |
Default method depends on OS and Python version and `fork` doesn’t work with the cherenkov_threshold hack in this PR.
|
Fixed the issue—turns out, @mcolomerm Please go ahead and try this branch now; I’ll merge it sometime after the Easter holidays if you don’t discover any further issues. |
Thanks @JostMigenda for having a look at this. I will try to test it on the coming days. |
Fixes #52. As a side effect (because the allowed eNu range for certain channels is now slightly larger), the event rate in
esandc12e/c12ebchannels increases by a few per cent for LS detectors.(Not 100% happy with how I implemented this, but I think that’s about as good as it gets without a larger restructuring of the code base. At least I got to clean up the
main()implementation slightly.)