Conversation
…manipuler les args apres, a tester :)
…manipuler les args apres, a tester :) EDIT: AJOUT GESTION LEAKS
…manipuler les args apres, a tester :) EDIT: AJOUT GESTION LEAKS
TChobert
requested changes
Feb 14, 2025
Collaborator
TChobert
left a comment
TChobert
left a comment
There was a problem hiding this comment.
Je ne peux pas approuver celle-ci pur une question de comportement du builtin. Sur le vrai echo si on met plus d'un argument, un message d'erreur est affiche.
je te laisse egalement verifier les autres cas du genre et le comportement du buitlin en general. Sinon bien vu pour l'update des variables avec getcwd, et le reste !
TChobert
approved these changes
Feb 14, 2025
Collaborator
TChobert
left a comment
TChobert
left a comment
There was a problem hiding this comment.
Ca me semble coherent et fonctionnel dans l'ensemble, GG, ca merge !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.