Conversation
…an RPC request while shutting down
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
n8mgr
reviewed
Mar 23, 2026
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
Must remove the |
ChrisSchinnerl
previously approved these changes
Mar 24, 2026
Member
ChrisSchinnerl
left a comment
ChrisSchinnerl
left a comment
There was a problem hiding this comment.
@Alrighttt code looks good. I added a little unit test to demonstrate how we usually unit test RHP4 code.
ChrisSchinnerl
approved these changes
Mar 24, 2026
peterjan
requested changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ThreadGroup to the RHP4 Server to enable graceful shutdown. During shutdown, in-flight RPCs complete before services close, and new RPCs are rejected with "host is shutting down" instead of failing mid-operation with "threadgroup closed" errors.
Fixes #412