ECHOES-891 Make toasts & modals compatible #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jeremy-davis-sonarsource
force-pushed
the
jay/toast-modal-collision
branch
from
0440a38 to
3ab8e31
Compare
|
|
|
||
| const ModalPortalRefContext = createContext<ModalPortalContextValue | null>(null); | ||
|
|
||
| export function ModalPortal({ children }: Readonly<PropsWithChildren>) { |
Contributor
There was a problem hiding this comment.
NP: as ModalPortal is the "meat" of this file IMO and is imported directly, I feel the file should be called ModalPortal.tsx - WDYT?
| toast! | ||
| </Button> | ||
| } | ||
| description="Clicking on the button will add a toast message. This shows that they appear on top and can be interacted with without closing the modal" |
Contributor
There was a problem hiding this comment.
pressing Esc still closes the modal and not the toast. This was already the case: toasts don't respond to Esc, but I'm now wondering if they should? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The easiest way to test this in SQ is to render a Modal that generates a toast anywhere in the app!