add ProjectGuid to ScintillaNET_FindReplaceDialog.csproj#17
Merged
Stumpii merged 1 commit intoStumpii:masterfrom May 9, 2025
Merged
add ProjectGuid to ScintillaNET_FindReplaceDialog.csproj#17Stumpii merged 1 commit intoStumpii:masterfrom
Stumpii merged 1 commit intoStumpii:masterfrom
Conversation
This is needed for WiX project harvesting so that generated IDs are unique, although specifying a ProjectGUID is optional in SDK-style projects. The value is taken from the solution file.
Contributor
Author
|
Note: Harvesting with Heat in WiX has been deprecated in WiX 6, but we are still using it for now. We noticed that our setup build broke when switching to modern .NET, SDK-style projects and removing the ProjectGuids from the .csproj files. ScintillaNET_FindReplaceDialog didn't have one from the beginning, apparently, but it didn't matter because it was the only such project up to now, so there were no duplicates. (Scintilla.NET does have a GUID). This is just for consistency, so that all projects we ship in our setup have a Guid. Feel free to close this if you think it is unneeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for WiX project harvesting so that generated IDs are unique, although specifying a ProjectGUID is optional in SDK-style projects.
The value is taken from the solution file.