fix: ungrammatical French translations of flash messages#1058
Draft
stlgaits wants to merge 1 commit intoSylius:1.15from
Draft
fix: ungrammatical French translations of flash messages#1058stlgaits wants to merge 1 commit intoSylius:1.15from
stlgaits wants to merge 1 commit intoSylius:1.15from
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ungrammatical French translations in flash messages by replacing gender-specific formulations with gender-neutral alternatives. The current translations are missing articles and suffer from gender agreement issues that make them sound unnatural in French.
Key changes:
- Replaced verb-based constructions with noun-based constructions (e.g., "a bien été créé" → "Création réussie")
- Used gender-neutral formulations to avoid article and adjective agreement complexities
- Improved error message clarity and formality
stlgaits
force-pushed
the
french-flashes
branch
from
cae5a9e to
522d217
Compare
Member
|
@stlgaits It's a very good idea. |
Member
|
I think we should base this branch on future minor versions, cause it could break UI tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The French translations for flash messages are currently ungrammatical as many are missing articles in front of resource nouns which makes it sound really off for instance :
Here,
Should be more something like "Le contact a bien été mis à jour.". However, if using a feminine noun for instance "Livraison" it should be
in the current version (which is not supported).
To avoid juggling between gender agreements of articles, nouns, adjectives and transitive verbs, I suggest in this PR to use gender-neutral formulations to have more natural-sounding and grammatically correct messages.