fix translatable resource not getting its translation mapped with AsResource#1132
Open
esserj wants to merge 1 commit intoSylius:1.13from
Open
fix translatable resource not getting its translation mapped with AsResource#1132esserj wants to merge 1 commit intoSylius:1.13from
esserj wants to merge 1 commit intoSylius:1.13from
Conversation
…esource while the translation gets a mapping to the resource fxes Sylius#1018
esserj
commented
Jan 13, 2026
|
|
||
| if (!$resourceMetadata->hasParameter('translation')) { | ||
| return; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
seems to be an artificial limitation?
| } | ||
|
|
||
| /** @var MetadataInterface $translationResourceMetadata */ | ||
| $translationResourceMetadata = $this->resourceMetadataRegistry->get($resourceMetadata->getAlias() . '_translation'); |
Contributor
Author
There was a problem hiding this comment.
we could also try catch here, but it seems to make sense that when you mark your entity translatable, you'd want an error that it cannot find your translation resource
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsResourcedoes not havetranslationsconfigurationand there seems to be no way to currently get it mapped properly when using attributes?
This ensures that when you
AsResourcetag your translation resource as<alias>_translation,the mapping occurs, even without the resource metadata translation parameter.
which seemed to be an artificial limitation also not implemented in the mapTranslation