Added LRC subtitle format#590
Open
makian123 wants to merge 4 commits intoTypesettingTools:masterfrom
Open
Conversation
makian123
commented
Apr 26, 2026
|
|
||
| // Add the LRC spacing | ||
| if(!dialog.Text->empty()){ | ||
| out_line += " "; |
Author
There was a problem hiding this comment.
I output in the format of
[TIMESTAMP] <TEXT>
instead of
[TIMESTAMP]<TEXT>
because i've seen LRCget output that format so i figured the spaces left of text dont matter so i just add it for readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have recently found that i have a need to import .lrc files. So i implemented the lrc format per the spec.
I haven't added tags as it says that some players might not support them.
Feel free to point out anything i have failed to to.