Skip to content

refactor(charts): use vite alias paths in stories and tests #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 4 commits into from
Apr 20, 2026
Merged

refactor(charts): use vite alias paths in stories and tests #8508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0114894
refactor(charts): use vite alias paths in stories and tests
Lukas742 Apr 20, 2026
9a8a1b8
Update TimeLineChart.mdx
Lukas742 Apr 20, 2026
de7c724
Merge branch 'main' into refactor/charts-alias-paths
Lukas742 Apr 20, 2026
da3e5e4
order imports
Lukas742 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/charts/src/components/BarChart/BarChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { complexDataSet } from '../../resources/DemoProps.js';
import { BarChart } from './index.js';
import {
cypressPassThroughTestsFactory,
testChartLegendConfig,
testChartZoomingTool,
testStackAggregateTotals,
} from '../../../../../cypress/support/utils';
import { complexDataSet } from '../../resources/DemoProps.js';
import { BarChart } from './index.js';
} from '@/cypress/support/utils';

const dimensions = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/BarChart/BarChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import LegendStory from '../../resources/LegendConfig.mdx';
Expand Down
6 changes: 1 addition & 5 deletions packages/charts/src/components/BulletChart/BulletChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import {
cypressPassThroughTestsFactory,
testChartLegendConfig,
testChartZoomingTool,
} from '../../../../../cypress/support/utils';
import { complexDataSet } from '../../resources/DemoProps.js';
import { BulletChart } from './index.js';
import { cypressPassThroughTestsFactory, testChartLegendConfig, testChartZoomingTool } from '@/cypress/support/utils';

const dimensions = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/BulletChart/BulletChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import LegendStory from '../../resources/LegendConfig.mdx';
Expand Down
6 changes: 3 additions & 3 deletions packages/charts/src/components/ColumnChart/ColumnChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { complexDataSet } from '../../resources/DemoProps.js';
import { ColumnChart } from './index.js';
import {
cypressPassThroughTestsFactory,
testChartLegendConfig,
testChartZoomingTool,
testStackAggregateTotals,
} from '../../../../../cypress/support/utils';
import { complexDataSet } from '../../resources/DemoProps.js';
import { ColumnChart } from './index.js';
} from '@/cypress/support/utils';

const dimensions = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/ColumnChart/ColumnChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import LegendStory from '../../resources/LegendConfig.mdx';
Expand Down
6 changes: 1 addition & 5 deletions packages/charts/src/components/ColumnChartWithTrend/ColumnChartWithTrend.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import {
cypressPassThroughTestsFactory,
testChartLegendConfig,
testChartZoomingTool,
} from '../../../../../cypress/support/utils';
import { complexDataSet } from '../../resources/DemoProps.js';
import { ColumnChartWithTrend } from './index.js';
import { cypressPassThroughTestsFactory, testChartLegendConfig, testChartZoomingTool } from '@/cypress/support/utils';

const dimensions = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/ColumnChartWithTrend/ColumnChartWithTrend.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import * as ComponentStories from './ColumnChartWithTrend.stories';
import LegendStory from '../../resources/LegendConfig.mdx';
Expand Down
6 changes: 3 additions & 3 deletions packages/charts/src/components/ComposedChart/ComposedChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { complexDataSet } from '../../resources/DemoProps.js';
import { ComposedChart } from './index.js';
import {
cypressPassThroughTestsFactory,
testChartLegendConfig,
testChartZoomingTool,
testStackAggregateTotals,
} from '../../../../../cypress/support/utils';
import { complexDataSet } from '../../resources/DemoProps.js';
import { ComposedChart } from './index.js';
} from '@/cypress/support/utils';

const dimensions = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/ComposedChart/ComposedChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import LegendStory from '../../resources/LegendConfig.mdx';
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/DonutChart/DonutChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '../../../../../cypress/support/utils';
import { complexDataSet, simpleDataSet } from '../../resources/DemoProps.js';
import { DonutChart } from './index.js';
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '@/cypress/support/utils';

const dimension = {
accessor: 'name',
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/DonutChart/DonutChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import * as ComponentStories from './DonutChart.stories';
import LegendStory from '../../resources/LegendConfig.mdx';
Expand Down
6 changes: 1 addition & 5 deletions packages/charts/src/components/LineChart/LineChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import {
cypressPassThroughTestsFactory,
testChartLegendConfig,
testChartZoomingTool,
} from '../../../../../cypress/support/utils';
import { complexDataSet } from '../../resources/DemoProps.js';
import { LineChart } from './index.js';
import { cypressPassThroughTestsFactory, testChartLegendConfig, testChartZoomingTool } from '@/cypress/support/utils';

const dimensions = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/LineChart/LineChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import * as ComponentStories from './LineChart.stories';
import LegendStory from '../../resources/LegendConfig.mdx';
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/PieChart/PieChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Text as RechartsText } from 'recharts';
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '../../../../../cypress/support/utils';
import { complexDataSet, simpleDataSet } from '../../resources/DemoProps.js';
import { PieChart } from './index.js';
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '@/cypress/support/utils';

const dimension = {
accessor: 'name',
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/PieChart/PieChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import * as ComponentStories from './PieChart.stories';
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/RadarChart/RadarChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '../../../../../cypress/support/utils';
import { complexDataSet } from '../../resources/DemoProps.js';
import { RadarChart } from './index.js';
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '@/cypress/support/utils';

const dimensions = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/RadarChart/RadarChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import * as ComponentStories from './RadarChart.stories';
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/RadialChart/RadialChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { cypressPassThroughTestsFactory } from '../../../../../cypress/support/utils';
import { RadialChart } from './index.js';
import { cypressPassThroughTestsFactory } from '@/cypress/support/utils';

describe('RadialChart', () => {
it('Basic', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/RadialChart/RadialChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import * as ComponentStories from './RadialChart.stories';

Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/ScatterChart/ScatterChart.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '../../../../../cypress/support/utils';
import { complexDataSet, scatterComplexDataSet } from '../../resources/DemoProps.js';
import { ScatterChart } from './index.js';
import { cypressPassThroughTestsFactory, testChartLegendConfig } from '@/cypress/support/utils';

const measures = [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/ScatterChart/ScatterChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta } from '@storybook/addon-docs/blocks';
import TooltipStory from '../../resources/TooltipConfig.mdx';
import * as ComponentStories from './ScatterChart.stories';
Expand Down
7 changes: 2 additions & 5 deletions packages/charts/src/components/TimelineChart/TimeLineChart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { ControlsWithNote, DocsHeader, Footer } from '../../../../../.storybook/components';
import { Canvas, Meta, Markdown, ArgTypes } from '@storybook/addon-docs/blocks';
import SubcomponentsSection from '../../../../../.storybook/docs/SubcomponentsSection.md?raw';
import { ControlsWithNote, DocsHeader, Footer } from '@sb/components';
import { Canvas, Meta, ArgTypes } from '@storybook/addon-docs/blocks';
import * as ComponentStories from './TimeLineChart.stories';
import { TimelineChartAnnotation } from './TimelineChartAnnotation';

Expand Down Expand Up @@ -133,8 +132,6 @@ A lot more things can be customized in the `TimelineChart`. These include:

<Canvas of={ComponentStories.LoadingPlaceholder} />

<Markdown>{SubcomponentsSection}</Markdown>

## TimelineChartAnnotation

The `TimelineChartAnnotation` is designed to be used for creating custom annotations, markers
Expand Down
Loading