Skip to content

fix: use pull_request.user.login instead of github.actor for bot check#1295

Merged
adamtheturtle merged 1 commit intomainfrom
fix/dependabot-actor-check
Mar 17, 2026
Merged

fix: use pull_request.user.login instead of github.actor for bot check#1295
adamtheturtle merged 1 commit intomainfrom
fix/dependabot-actor-check

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Mar 17, 2026

Fixes adamtheturtle/literalizer#146

The github.actor check is unreliable - it reflects who triggered the workflow, not who opened the PR. Use github.event.pull_request.user.login instead.

Flagged by zizmor bot-conditions audit.

Made with Cursor


Note

Low Risk
Low risk change limited to a GitHub Actions conditional and a lint configuration cleanup; main impact is whether Dependabot PRs are correctly auto-merged.

Overview
Updates the Dependabot auto-merge GitHub Action to gate execution on github.event.pull_request.user.login == 'dependabot[bot]' instead of github.actor, ensuring the check reflects the PR author rather than the workflow trigger.

Cleans up zizmor.yml by removing the bot-conditions rule disable now that the workflow no longer relies on the flagged pattern.

Written by Cursor Bugbot for commit 5d1d134. This will update automatically on new commits. Configure here.

@adamtheturtle adamtheturtle force-pushed the fix/dependabot-actor-check branch from bad457b to 5d1d134 Compare March 17, 2026 09:13
@adamtheturtle adamtheturtle merged commit 637f831 into main Mar 17, 2026
30 checks passed
@adamtheturtle adamtheturtle deleted the fix/dependabot-actor-check branch March 17, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependabot-merge.yml: use pull_request.user.login instead of github.actor for bot check

1 participant