Skip to content

fix: HTTP node now forwards headers input to the request#3

Open
sjoerdvink99 wants to merge 1 commit intoWeaveMindAI:mainfrom
sjoerdvink99:fix/http-node-forward-headers
Open

fix: HTTP node now forwards headers input to the request#3
sjoerdvink99 wants to merge 1 commit intoWeaveMindAI:mainfrom
sjoerdvink99:fix/http-node-forward-headers

Conversation

@sjoerdvink99
Copy link
Copy Markdown
Contributor

What and why

The HTTP node declares a headers: Dict[String, String] input port but never reads it. Any headers wired in are silently dropped.

How

Read the headers input port in execute and forward each key-value pair into a reqwest::HeaderMap. Also switch from reqwest::Client::new() on every call to the shared ctx.http_client.

Linked issue

X

Type of change

  • Bug fix
  • New feature
  • New node
  • Language change (parser, type system, executor)
  • Dashboard change
  • Docs
  • Refactor
  • Other:

Checklist

  • cargo build, cargo test, and cargo clippy pass.
  • pnpm -C dashboard check passes (if frontend changed).
  • New code has tests. Bug fixes have a regression test.
  • No unrelated formatting churn.
  • No commented-out code.
  • No TODO or FIXME without a linked issue.
  • If this is a node, backend and frontend port names/types match, and I built a tiny project that uses it end to end.
  • If this is a language change, I opened an issue first and it was approved.

Screenshots / demo (if applicable)

X

Anything reviewers should pay extra attention to

X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant