fix: HTTP node now forwards headers input to the request#3
Open
sjoerdvink99 wants to merge 1 commit intoWeaveMindAI:mainfrom
Open
fix: HTTP node now forwards headers input to the request#3sjoerdvink99 wants to merge 1 commit intoWeaveMindAI:mainfrom
sjoerdvink99 wants to merge 1 commit intoWeaveMindAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The HTTP node declares a headers: Dict[String, String] input port but never reads it. Any headers wired in are silently dropped.
How
Read the headers input port in execute and forward each key-value pair into a reqwest::HeaderMap. Also switch from reqwest::Client::new() on every call to the shared ctx.http_client.
Linked issue
X
Type of change
Checklist
cargo build,cargo test, andcargo clippypass.pnpm -C dashboard checkpasses (if frontend changed).TODOorFIXMEwithout a linked issue.Screenshots / demo (if applicable)
X
Anything reviewers should pay extra attention to
X