fix: update cursor set command examples to show correct usage.#133
fix: update cursor set command examples to show correct usage.#133splindsay-92 wants to merge 9 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated documentation and example usage across three files to reflect a change in the Ably Spaces cursors set command interface—replacing a single Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ffdb8f1 to
c9fda33
Compare
c9fda33 to
a68d650
Compare
| env: | ||
| E2E_ABLY_API_KEY: ${{ secrets.E2E_ABLY_API_KEY }} | ||
| E2E_ABLY_ACCESS_TOKEN: ${{ secrets.E2E_ABLY_ACCESS_TOKEN }} | ||
| TERMINAL_SERVER_SIGNING_SECRET: ${{ secrets.TERMINAL_SERVER_SIGNING_SECRET }} |
There was a problem hiding this comment.
Rate-limit test bypass silently enabled by signing secret
Medium Severity
The rate-limit test group now has TERMINAL_SERVER_SIGNING_SECRET set, and the bypass checks were changed from CI_BYPASS_SECRET to TERMINAL_SERVER_SIGNING_SECRET. Previously, CI_BYPASS_SECRET was intentionally excluded from the rate-limit test group (as noted in the workflow comments) so rate limiting would remain active. Now, since the signing secret doubles as the bypass flag, the test rate limiter is effectively disabled (1000 connections, 0 pause) and the global setup initial delay is skipped, undermining the rate-limit test's purpose.
Additional Locations (2)
e732088 to
cade3f0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


The spaces command examples were showing the usage of a
--positionflag which doesn't actually exist. Updated to show correct usage or--xand--yflags.Note
Medium Risk
Touches CI auth/bypass gating and changes the default terminal endpoint used by tests, which can affect E2E reliability and environment safety if secrets/endpoints are misconfigured.
Overview
Updates Web CLI E2E/CI to use
TERMINAL_SERVER_SIGNING_SECRETas the bypass signal/secret (replacingCI_BYPASS_SECRET), wires it into GitHub Actions env +.env.test, and disables initial rate-limit delays/limits when the secret is present.Switches the default WebSocket endpoint from
wss://web-cli.ably.comtowss://web-cli-terminal.ably-dev.comacross the web example app and extensive unit/E2E tests (including domain-scoped storage keys and connectivity checks), and setsNO_COLOR=1in CI workflows.Fixes
ably spaces cursorsdocs/examples (README + command help) to show the correct--x/--yusage instead of a non-existent--positionflag.Written by Cursor Bugbot for commit d2971c2. This will update automatically on new commits. Configure here.
Summary by CodeRabbit