Delete Agent via button on FE

[abjjabjj]

https://www.loom.com/share/e0b7154b54df4e5482ef62cd136c25fa?sid=9500ea6c-8cd4-429b-9ce3-b060188cffae

Will probably do a touchup on placement and button interaction, but the video demonstrates the functionality. You obviously need owner/edit rights on the agent.

---

Important

Add DeleteAgentButton to frontend for agent deletion with confirmation dialog, and refactor related components and imports.

• Feature:
  • Add DeleteAgentButton component in delete-button.tsx to allow users to delete agents with confirmation dialog.
  • Integrate DeleteAgentButton into page.tsx for agent edit page, visible to users with owner/edit rights.
• UI Components:
  • Add alert-dialog.tsx for confirmation dialogs, used in DeleteAgentButton.
• API:
  • Add deleteAgent() function in agent.ts to handle agent deletion.
• Refactoring:
  • Rename create-agent-button.tsx to create-button.tsx and update imports in user-sidebar.tsx.
• Misc:
  • Remove unused text-sm attribute in accordion.tsx.

^{This description was created by for 1ce09b1. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to 1ce09b1 in 1 minute and 45 seconds. Click for details.

• Reviewed 373 lines of code in 8 files
• Skipped 1 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. apps/frontend/components/agent/delete-button.tsx:27

• Draft comment:
  Consider adding a pending/loading state (and disabling the delete button) during the deletion process to prevent duplicate submissions and to provide user feedback. This is mentioned as a TODO but is important for ensuring a robust UX.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the suggestion is valid and important for UX, it's already explicitly noted as a TODO in the code. The comment doesn't provide any additional technical insight or specific implementation details beyond what the developer has already acknowledged. Following our rules, we should avoid making comments that don't require immediate action beyond what's already planned. The comment does provide a good explanation of why the loading state is important (preventing duplicate submissions). Maybe this additional context is valuable? While the explanation is helpful, it's still fundamentally restating something the developer has already acknowledged they need to do. The prevention of duplicate submissions is a standard consideration for loading states. The comment should be deleted as it merely restates an already-acknowledged TODO without providing actionable new information.

2. apps/frontend/components/agent/delete-button.tsx:43

• Draft comment:
  Typo: In the deletion failure toast, the title says "Unable to stop Agent {name}" but this should likely be "Unable to delete Agent {name}".
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_eoDiKE6gKOokfQYF

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

The toast error message in the deletion error block incorrectly uses 'Unable to stop Agent' instead of 'Unable to delete Agent'. Please update the title to accurately reflect the error context.

Suggested change

	title: `Unable to stop Agent ${name}`,
	title: `Unable to delete Agent ${name}`,

[alpuga]

Yeah, this makes sense. Just switch stop to delete inside of the console.error under deleteResult.

[alpuga]

Just the small fix in delete-button.tsx that ellipsis pointed out.