Setup DB connection so that DB errors raise exceptions#1322
Open
nicolasbrossard wants to merge 1 commit intoaces:mainfrom
Open
Setup DB connection so that DB errors raise exceptions#1322nicolasbrossard wants to merge 1 commit intoaces:mainfrom
nicolasbrossard wants to merge 1 commit intoaces:mainfrom
Conversation
Contributor
|
Failing CI is fixed on main if you're interested. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 20 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the call to the
connectmethod in classNeuroDB::DBIso that when a DB error occurs, it raises an exception (which in most cases halts script execution immediately).