[SQL/physiological] Remove physiological file dummy date default#10410
Open
MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
Open
[SQL/physiological] Remove physiological file dummy date default#10410MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
Conversation
MaximeBICMTL
added
Category: Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
physiological_tablefield is nullable, yet it uses a dummy date as a default. Although the imaging scripts seem to always put a date manually, a dummy date is a bad practice as it is harder to be sure whether a date is real or not.Solution
Just use
NULLas a default instead.Testing
Ran the patch in Raisinbread and checked that nothing bad happened.