[SQL/MEG] Add physiological_file.DownloadPath field#10411
Open
MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
Open
[SQL/MEG] Add physiological_file.DownloadPath field#10411MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
physiological_file.DownloadPath field#10411MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
Conversation
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Slack.
Problem
For the EEG data types that LORIS currently handles, the acquisition files are "real" files, which is very nice. However, for the MEG CTF data types, the acquisition files are actually directories. The BIDS specification says that these MEG CTF acquisitions must be stored as directories, not as archives, and the neuroscience libraries like MNE only work on directories. As such, it makes sense to store the MEG CTF as directories in the LORIS BIDS dataset. However, the users must also be able to download these acquisition files, which is problematic if those are directories.
Solution
Split
physiological_file.FilePathinto two fieldsFilePath(stays the same) andDownloadPath(new field):FilePathfield points to the directory in the BIDS dataset, and theDownloadPathpoints to an archive of that directory.Whenever computation needs to be done in the dataset, the
FilePathfield is used, whenever the user wants to download an acquisition file,DownloadPathis used.Testing
physiological_file.FilePathin the electrophysiology_modules.DownloadPathto an invalid value only breaks the main file download.