Conversation
|
Claude finished @kaghni's task in 59s —— View job Two issues found:
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| const { existsSync, unlinkSync } = await import("node:fs"); | ||
| const { join } = await import("node:path"); | ||
| const { homedir } = await import("node:os"); | ||
| const credFile = join(homedir(), ".deeplake", "credentials.json"); |
There was a problem hiding this comment.
The credentials path is re-derived here instead of reusing the CREDS_PATH constant already defined in auth.ts — if the path ever changes there, logout won't follow. Export a deleteCredentials() function from auth.ts (wrapping unlinkSync(CREDS_PATH)) and call it here instead.
Comment on lines
+139
to
+141
| const { existsSync, unlinkSync } = await import("node:fs"); | ||
| const { join } = await import("node:path"); | ||
| const { homedir } = await import("node:os"); |
There was a problem hiding this comment.
Dynamic imports for node:fs, node:path, and node:os are unnecessary — these are static built-ins already imported at the top of auth.ts. Use static imports at the top of this file (or better, delegate to a deleteCredentials() in auth.ts as noted above).
efenocchi
approved these changes
Apr 14, 2026
efenocchi
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
logoutcommand that removes ~/.deeplake/credentials.json.