Fix Sub VFO blank at startup (issue #19 follow-up)#30
Closed
adecarolis wants to merge 1 commit intomasterfrom
Closed
Fix Sub VFO blank at startup (issue #19 follow-up)#30adecarolis wants to merge 1 commit intomasterfrom
adecarolis wants to merge 1 commit intomasterfrom
Conversation
receiveCache previously sent all funcFreq/funcMode updates as the generic "frequency"/"mode" fields, regardless of which receiver produced them. On cmd29 rigs (IC-7610 etc) this caused Sub receiver poll responses to overwrite the Main display (or be silently dropped on A/B rigs where funcUnselectedFreq wasn't mapped), leaving the Sub VFO display blank at startup until the user manually switched. Detect VFO B updates (receiver=1 on cmd29, or funcUnselectedFreq/Mode otherwise) and route them to vfoBFrequency so the browser's Sub VFO display populates from the normal periodic-polling flow. Sub mode updates are dropped (no Sub mode field in the UI) rather than overwriting the Main mode. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
receiveCachesent all freq/mode cache updates as the genericfrequency/modefields, ignoringitem.receiver. On cmd29 rigs (IC-7610, IC-785x, etc.), Sub receiver responses either overwrote the Main display or were silently dropped (A/B rigs'funcUnselectedFreqwasn't even in the mapping).receiver == 1on cmd29, orfuncUnselectedFreq/Modeon A/B rigs) and route them tovfoBFrequency, so the normal periodic-polling flow populates the Sub display automatically. Sub mode updates are dropped since the UI has no Sub mode field.Test plan
qmake wfweb.pro && make -j— builds cleanpytest .— 49/49 tests pass🤖 Generated with Claude Code