fix: unstack aggsender unset claims#1569
Open
arnaubennassar wants to merge 5 commits intorelease/0.8from
Open
Conversation
arnaubennassar
changed the title
|
joanestebanr
reviewed
Apr 7, 2026
| "%s, unclaim_block=%d, cert_range=%d-%d", | ||
| formatClaimForLogs(*assessment.culpritClaim), assessment.culpritUnclaim, certParams.FromBlock, certParams.ToBlock) | ||
| } | ||
| if assessment != nil && assessment.cutBlock != 0 { |
Collaborator
There was a problem hiding this comment.
Reduce complexity adding an no action required if:
if assessment == nil {
return certParams, nil
}
| maxCertSize := f.cfg.MaxCertSize | ||
| for { | ||
| if maxCertSize == 0 || currentCert.EstimatedSize() <= maxCertSize { | ||
| if originalCert != nil && currentCert != nil && currentCert.ToBlock < originalCert.ToBlock { |
Collaborator
There was a problem hiding this comment.
originalCert must be always != nil, same for currentCert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Changes Summary
the same candidate certificate but the unclaims happen in a different order.
global index, token, and amount.
MaxCertSizeorMaxL2BlockNumberwould prevent the matching unclaim fromfitting into the same certificate, and suggest the config change needed to unblock aggsender.
None
📋 Config Updates
None
✅ Testing
go test ./aggsender/flowsordering.
within the same candidate certificate.
🐞 Issues
🔗 Related PRs
feat/fix-removeger-tool-docs: hardening intools/remove_gerused to clean the invalidGER incident and confirm the network state before fixing aggsender recovery behavior.
📝 Notes
logic required later invalid claims to be unclaimed no later than earlier ones. That was
stricter than the final imported-bridge-exit construction, which only requires claim/unclaim
pairs to cancel out within the same certificate.
recoverable when its matching unclaim is also inside the same candidate certificate.