Conversation
Global toolbox-env.* files in ~/.claude/ used last-write-wins semantics via Path.write_text(), causing each new environment configuration to overwrite the previous one and producing stale/incomplete environment state for multi-config users.
Shell profiles (.bashrc, .zshrc, .profile, config.fish) are the authoritative persistence layer and correctly accumulate variables across multiple configurations.
Per-command env.* files remain unchanged as they are correctly scoped and auto-loaded by launchers.
BREAKING CHANGE: generate_env_loader_files() no longer creates toolbox-env.sh, toolbox-env.fish, toolbox-env.ps1, or toolbox-env.cmd in ~/.claude/.
Users who manually sourced these files should open a new terminal instead, which loads variables from shell profiles.
Per-command env.* files in ~/.claude/{cmd}/ are unaffected.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global toolbox-env.* files in ~/.claude/ used last-write-wins semantics via Path.write_text(), causing each new environment configuration to overwrite the previous one and producing stale/incomplete environment state for multi-config users. Shell profiles (.bashrc, .zshrc, .profile, config.fish) are the authoritative persistence layer and correctly accumulate variables across multiple configurations. Per-command env.* files remain unchanged as they are correctly scoped and auto-loaded by launchers.
BREAKING CHANGE: generate_env_loader_files() no longer creates toolbox-env.sh, toolbox-env.fish, toolbox-env.ps1, or toolbox-env.cmd in ~/.claude/. Users who manually sourced these files should open a new terminal instead, which loads variables from shell profiles. Per-command env.* files in ~/.claude/{cmd}/ are unaffected.