Draft
Conversation
7865c9b to
b83f440
Compare
b83f440 to
5efaeb5
Compare
Contributor
|
I think trying to keep the publishing processes between projects owned by the GOV.UK Design System team makes a ton of sense. To that end, is there any value in considering abstracting some of these scripts - my gut is probably not at this point but just a thought. On Finally if we adopt this, would we remove the existing scripts and guidance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it says. This copies Frontend's current strategy of managing releases as a multi-step process in CI rather than doing anything locally. This includes the github workflows themselves plus the helper scripts and their tests, which I've put in /scripts/github-actions
Finishing and validating this means we can delete the (broken) automated release scripts that the kit currently runs off of.
Like Frontend, this splits the process into 3 parts:
This is also missing CI secrets that allow us to run some of these.
Differences between the kit and Frontend
The kit tends to use simpler changelog titles ie: no 'v' before the version number and no release 'type' after the number eg: "v1.1.1 (fix release)". There's also not precident for the kit to do pre-releases like betas or rc's at the moment. Therefore I've simplified the helper scripts to not include interrogating differences between pre-releases and full releases or building complex titles.
The kit uses clean publish to handle publishing to npm rather than 'manual' publishing like Frontend does. It similarly don't appear to be as concerned with tagging. I've therefore simplified the publish to npm job to follow this release flow.