Skip to content

🎨 Palette: Add Contextual Loading to Generate Button#23

Open
google-labs-jules[bot] wants to merge 1 commit intomainfrom
palette-contextual-loading-9323278080169107514
Open

🎨 Palette: Add Contextual Loading to Generate Button#23
google-labs-jules[bot] wants to merge 1 commit intomainfrom
palette-contextual-loading-9323278080169107514

Conversation

@google-labs-jules
Copy link
Copy Markdown

💡 What

Replaced the disruptive, full-screen loading overlay with a contextual loading spinner inside the "Generate Poster" button.

🎯 Why

The previous full-screen overlay blocked the entire UI during poster generation, creating a jarring user experience. This new implementation provides a smoother, more modern feel by showing progress directly on the button the user interacted with, without interrupting their workflow.

📸 Before/After

Before: A full-screen semi-opaque overlay with a spinner would cover the entire page.
After: The "Generate Poster" button itself now shows a spinner, and the button is temporarily disabled.

A button showing a loading spinner inside it.

♿ Accessibility

  • When the loading state is active, the button's visible text changes to "Generating...".
  • The button's aria-label is dynamically set to "Generating poster, please wait." to ensure screen reader users are clearly informed that an action is in progress.
  • The previous loading overlay's text ("Generating your masterpiece...") has been preserved in this new accessible name.

PR created automatically by Jules for task 9323278080169107514 started by @anaxifty

Replaces the disruptive full-screen loading overlay with a contextual loading spinner inside the "Generate Poster" button.

This improves the user experience by providing immediate, non-blocking feedback directly on the interactive element.

The implementation includes:
- A new loading state for the primary button with a spinner.
- Updated JavaScript to manage the button's disabled, loading, and accessible states.
- Removal of the old, redundant loading overlay element and styles.

Accessibility is addressed by dynamically updating the button's text and `aria-label` to "Generating..." and "Generating poster, please wait." respectively, ensuring screen reader users are informed of the ongoing action.
@google-labs-jules
Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants