Skip to content

🎨 Palette: Enhance Button Loading State #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Enhance Button Loading State #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web_app/static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ <h2 id="contentHeading">Lyrics</h2>
</div>
</div>

<button id="generateBtn" class="primary-btn">Generate Poster</button>
<button id="generateBtn" class="primary-btn">
<span class="btn-text">Generate Poster</span>
<div class="spinner" style="display: none;"></div>
</button>
</div>
</div>

Expand Down
27 changes: 21 additions & 6 deletions web_app/static/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const startLineInput = document.getElementById('startLine');
const endLineInput = document.getElementById('endLine');
const themeInput = document.getElementById('themeInput');
const fontInput = document.getElementById('fontInput');
const loadingOverlay = document.getElementById('loadingOverlay');
const loadingOverlay = document.getElementById('loadingOverlay'); // Keep for now, might be used elsewhere

let currentMetadata = null;
let searchDebounceTimer = null;
Expand Down Expand Up @@ -611,9 +611,17 @@ function handleLyricLineClick(lineNumber) {
}

async function generatePoster() {
if (!currentMetadata) return;
if (!currentMetadata || generateBtn.classList.contains('loading')) return;

loadingOverlay.style.display = 'flex';
const btnText = generateBtn.querySelector('.btn-text');
const spinner = generateBtn.querySelector('.spinner');

// --- 1. Set Loading State ---
generateBtn.classList.add('loading');
generateBtn.disabled = true;
btnText.textContent = 'Generating...'; // Update text for visual consistency
generateBtn.setAttribute('aria-label', 'Generating poster, please wait'); // Set accessible name
spinner.style.display = 'block';

const indexingToggle = document.getElementById('indexingToggle');
const accentToggle = document.getElementById('accentToggle');
Expand All @@ -635,8 +643,8 @@ async function generatePoster() {
const end = endVal;

if (isNaN(start) || isNaN(end) || start >= end) {
loadingOverlay.style.display = 'none';
showToast("Please enter a valid range (Start must be less than End).", "error");
// No loading overlay to hide, just return
return;
}

Expand Down Expand Up @@ -669,13 +677,20 @@ async function generatePoster() {
posterContainer.innerHTML = '';
posterContainer.appendChild(img);
showDownloadButton(imageUrl, data.filename);
loadingOverlay.style.display = 'none';
// No loading overlay to hide
};

} catch (error) {
console.error("Generation failed", error);
showToast(`Error: ${error.message}`, "error");
loadingOverlay.style.display = 'none';
// No loading overlay to hide
} finally {
// --- 2. Reset Button State ---
generateBtn.classList.remove('loading');
generateBtn.disabled = false;
btnText.textContent = 'Generate Poster';
generateBtn.removeAttribute('aria-label'); // Remove accessible name
spinner.style.display = 'none';
}
}

Expand Down
22 changes: 22 additions & 0 deletions web_app/static/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,28 @@ header p {
border-color: var(--text-muted);
}

.primary-btn.loading {
cursor: not-allowed;
background: var(--accent-hover);
}

.primary-btn.loading .btn-text {
display: none;
}

.primary-btn.loading .spinner {
display: block;
margin-bottom: 0; /* Override default margin */
}

/* Scoped spinner for button */
.primary-btn .spinner {
width: 20px;
height: 20px;
border-width: 2px;
border-top-color: #1a1a1f; /* Dark color for contrast */
}

/* Inputs */
input[type="text"],
input[type="number"] {
Expand Down