Skip to content

🎨 Palette: Add loading state to Generate button #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add loading state to Generate button #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web_app/static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ <h2 id="contentHeading">Lyrics</h2>
</div>
</div>

<button id="generateBtn" class="primary-btn">Generate Poster</button>
<button id="generateBtn" class="primary-btn">
<span class="btn-text">Generate Poster</span>
<span class="spinner" style="display: none;"></span>
</button>
</div>
</div>

Expand Down
49 changes: 33 additions & 16 deletions web_app/static/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,31 @@ function handleLyricLineClick(lineNumber) {
async function generatePoster() {
if (!currentMetadata) return;

loadingOverlay.style.display = 'flex';
const btnText = generateBtn.querySelector('.btn-text');
const spinner = generateBtn.querySelector('.spinner');

const resetGenerateButton = () => {
generateBtn.disabled = false;
generateBtn.removeAttribute('aria-label');
if (btnText) btnText.style.display = 'inline-block';
if (spinner) spinner.style.display = 'none';
};

// Validate before setting loading state
if (currentMetadata.type === 'track') {
const startVal = parseInt(startLineInput.value) || 1;
const endVal = parseInt(endLineInput.value) || 1;
if (isNaN(startVal) || isNaN(endVal) || startVal >= endVal) {
showToast("Please enter a valid range (Start must be less than End).", "error");
return;
}
}

// Set loading state
generateBtn.disabled = true;
generateBtn.setAttribute('aria-label', 'Generating poster, please wait.');
if (btnText) btnText.style.display = 'none';
if (spinner) spinner.style.display = 'inline-block';

const indexingToggle = document.getElementById('indexingToggle');
const accentToggle = document.getElementById('accentToggle');
Expand All @@ -628,23 +652,12 @@ async function generatePoster() {
};

if (payload.type === 'track') {
// Lyrics Logic (Same as before)
const startVal = parseInt(startLineInput.value) || 1;
const endVal = parseInt(endLineInput.value) || 1;
const start = startVal - 1;
const end = endVal;

if (isNaN(start) || isNaN(end) || start >= end) {
loadingOverlay.style.display = 'none';
showToast("Please enter a valid range (Start must be less than End).", "error");
return;
}

payload.lyrics_start = start;
payload.lyrics_end = end;
payload.lyrics_start = startVal - 1;
payload.lyrics_end = endVal;

} else {
// Album Logic
payload.indexing = indexingToggle ? indexingToggle.checked : false;
}

Expand All @@ -669,13 +682,17 @@ async function generatePoster() {
posterContainer.innerHTML = '';
posterContainer.appendChild(img);
showDownloadButton(imageUrl, data.filename);
loadingOverlay.style.display = 'none';
resetGenerateButton();
};
img.onerror = () => {
showToast('Failed to load the generated poster image.', 'error');
resetGenerateButton();
};

} catch (error) {
console.error("Generation failed", error);
showToast(`Error: ${error.message}`, "error");
loadingOverlay.style.display = 'none';
resetGenerateButton();
}
}

Expand Down