Skip to content

🎨 Palette: Add loading state to Generate Poster button #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add loading state to Generate Poster button #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions web_app/static/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,8 @@ function handleLyricLineClick(lineNumber) {
async function generatePoster() {
if (!currentMetadata) return;

loadingOverlay.style.display = 'flex';
generateBtn.disabled = true;
generateBtn.innerHTML = `<span class="btn-spinner"></span> Generating...`;

const indexingToggle = document.getElementById('indexingToggle');
const accentToggle = document.getElementById('accentToggle');
Expand All @@ -628,23 +629,21 @@ async function generatePoster() {
};

if (payload.type === 'track') {
// Lyrics Logic (Same as before)
const startVal = parseInt(startLineInput.value) || 1;
const endVal = parseInt(endLineInput.value) || 1;
const start = startVal - 1;
const end = endVal;

if (isNaN(start) || isNaN(end) || start >= end) {
loadingOverlay.style.display = 'none';
showToast("Please enter a valid range (Start must be less than End).", "error");
generateBtn.disabled = false;
generateBtn.innerHTML = 'Generate Poster';
return;
}

payload.lyrics_start = start;
payload.lyrics_end = end;

} else {
// Album Logic
payload.indexing = indexingToggle ? indexingToggle.checked : false;
}

Expand All @@ -663,19 +662,23 @@ async function generatePoster() {
const data = await response.json();
const imageUrl = data.is_base64 ? data.image_data : `${data.image_url}?t=${new Date().getTime()}`;

const img = document.createElement('img');
const img = new Image();
img.src = imageUrl;
img.onload = () => {
posterContainer.innerHTML = '';
posterContainer.appendChild(img);
showDownloadButton(imageUrl, data.filename);
loadingOverlay.style.display = 'none';
};
img.onerror = () => {
showToast("Error: Failed to load the generated image.", "error");
}

} catch (error) {
console.error("Generation failed", error);
showToast(`Error: ${error.message}`, "error");
loadingOverlay.style.display = 'none';
} finally {
generateBtn.disabled = false;
generateBtn.innerHTML = 'Generate Poster';
}
}

Expand Down
24 changes: 24 additions & 0 deletions web_app/static/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ header p {
display: inline-flex;
align-items: center;
justify-content: center;
gap: var(--space-2);
height: 44px;
/* Improved tap target */
padding: 0 var(--space-6);
Expand All @@ -166,6 +167,29 @@ header p {
transform: translateY(-1px);
}

.primary-btn:disabled {
opacity: 0.6;
cursor: not-allowed;
transform: none;
}

/* Spinner for inside buttons */
.btn-spinner {
width: 18px;
height: 18px;
border: 2px solid rgba(0, 0, 0, 0.2);
border-top-color: #1a1a1f;
/* Match button text color */
border-radius: 50%;
animation: spin 0.8s linear infinite;
}

@keyframes spin {
to {
transform: rotate(360deg);
}
}

.secondary-btn {
background: transparent;
border-color: var(--border-color);
Expand Down