Skip to content

[aria/multiple] Add to and clean up input validation across aria components #32713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adolgachev merged 2 commits into from
Jan 28, 2026
Merged

[aria/multiple] Add to and clean up input validation across aria components #32713

adolgachev merged 2 commits into from
Jan 28, 2026

Conversation

@adolgachev
Copy link
Contributor

@adolgachev adolgachev commented Jan 27, 2026 •
edited
Loading

Added one more validation check for tree when setting multiple values on a single select.
Removed validate method with no checks.

Went through other components and didn't see a practical need for other checks on inputs.

Will do another run-through to see if other mistakes can be validated.

@adolgachev adolgachev changed the title [aria/multiple] Fix up validation [aria/multiple] Add to and clean up input validation across aria components Jan 27, 2026
@adolgachev adolgachev marked this pull request as ready for review January 27, 2026 21:46
@adolgachev adolgachev requested review from tjshiu and removed request for andrewseguin and wagnermaciel January 27, 2026 21:47
@pullapprove pullapprove bot requested a review from wagnermaciel January 27, 2026 21:47
@adolgachev adolgachev requested review from ok7sai and removed request for wagnermaciel January 27, 2026 21:47
@adolgachev adolgachev added Accessibility This issue is related to accessibility (a11y) action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit target: patch This PR is targeted for the next patch release labels Jan 27, 2026
@adolgachev adolgachev added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 28, 2026
@adolgachev adolgachev removed the request for review from ok7sai January 28, 2026 21:39
@adolgachev adolgachev removed the action: presubmit The PR is in need of a google3 presubmit label Jan 28, 2026
@adolgachev adolgachev merged commit dbb94dc into angular:main Jan 28, 2026
38 of 40 checks passed
@adolgachev
Copy link
Contributor Author

adolgachev commented Jan 28, 2026

This PR was merged into the repository. The changes were merged into the following branches:

adolgachev added a commit that referenced this pull request Jan 28, 2026
@adolgachev
[aria/multiple] Add to and clean up input validation across aria comp…
ad0aeaa 
…onents (#32713)

* fix(aria/toolbar): remove unnnecessary validation methods

* fix(aria/tree): add validation for single selection tree with multiple values

(cherry picked from commit dbb94dc)
@adolgachev adolgachev deleted the aria-validation branch January 28, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjshiu tjshiu tjshiu approved these changes

Assignees

No one assigned

Labels

Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adolgachev @tjshiu