[Hotfix] Fix CI Docker API compatibility for Testcontainers#4091
Open
j1wonpark wants to merge 1 commit intoapache:masterfrom
Open
[Hotfix] Fix CI Docker API compatibility for Testcontainers#4091j1wonpark wants to merge 1 commit intoapache:masterfrom
j1wonpark wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4091 +/- ##
============================================
+ Coverage 22.39% 28.72% +6.33%
- Complexity 2552 3947 +1395
============================================
Files 458 656 +198
Lines 42116 52398 +10282
Branches 5917 6642 +725
============================================
+ Hits 9433 15053 +5620
- Misses 31871 36244 +4373
- Partials 812 1101 +289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GitHub Actions runner updated Docker engine to require minimum API version 1.44, but Testcontainers uses docker-java which defaults to API version 1.32, causing test failures. - Upgrade Testcontainers in amoro-ams from 1.17.2/1.19.6 to 1.20.1 - Add docker-java.properties with api.version=1.44 to amoro-ams and amoro-mixed-flink-common test resources - Update dev/deps/dependencies-hadoop-2-spark-3.3 for changed transitive dependencies Signed-off-by: Jiwon Park <jpark92@outlook.kr>
872cbf0 to
b95ed43
Compare
Contributor
Author
|
@xxubai @zhoujinsong Could you please review this PR? This fixes CI failures caused by Docker 29+ requiring minimum API version 1.44, which is incompatible with docker-java's default API version 1.32 used by Testcontainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
GitHub Actions runner updated its Docker engine to Docker 29+, which raised the minimum API version from 1.24 to 1.44. The
docker-javalibrary used by Testcontainers defaults to API version 1.32, causingAmoroAMSTestand Kafka-based Flink tests to fail with:This breaks all CI workflows (Core/hadoop2, Core/hadoop3, Deps, Trino).
See: testcontainers/testcontainers-java#11210
Brief change log
docker-java.propertieswithapi.version=1.44toamoro-amsandamoro-mixed-flink-commontest resources to override docker-java's default API versionamoro-ams/pom.xmlfrom 1.17.2/1.19.6 to 1.20.1 (aligned with existingk3sartifact version)dev/deps/dependencies-hadoop-2-spark-3.3to reflect changed transitive dependencies (guava 14.0.1 → 32.1.1-jre, error_prone_annotations 2.10.0 → 2.18.0, added failureaccess, j2objc-annotations, listenablefuture)How was this patch tested?
AmoroAMSTestpasses with Docker 29+ after addingdocker-java.propertiesDocumentation