Fix plugin source null reference exception#1630
Open
NizhynTech wants to merge 1 commit intoapache:masterfrom
Open
Fix plugin source null reference exception#1630NizhynTech wants to merge 1 commit intoapache:masterfrom
NizhynTech wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1630 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 18 18
Lines 5312 5312
=======================================
Hits 4261 4261
Misses 1051 1051 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
This might need the same fix in the install path... It might actually be better to fix this in cordova-common and ensure that all of the podspec values fall back to an empty array instead of being null/undefined: https://github.com/apache/cordova-common/blob/82c1b2f259f59423b3f59630142ea452cdf9be7a/src/PluginInfo/PluginInfo.js#L290-L298 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
IOS
Motivation and Context
Description
cordova-plugin-advanced-websocket add/remove throw an error because source is null
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))