Skip to content

Fix plugin source null reference exception#1630

Open
NizhynTech wants to merge 1 commit intoapache:masterfrom
NizhynTech:patch-1
Open

Fix plugin source null reference exception#1630
NizhynTech wants to merge 1 commit intoapache:masterfrom
NizhynTech:patch-1

Conversation

@NizhynTech
Copy link
Copy Markdown

Platforms affected

IOS

Motivation and Context

Description

cordova-plugin-advanced-websocket add/remove throw an error because source is null

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.21%. Comparing base (6a130fd) to head (06cd6a6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   80.21%   80.21%           
=======================================
  Files          18       18           
  Lines        5312     5312           
=======================================
  Hits         4261     4261           
  Misses       1051     1051           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpogue
Copy link
Copy Markdown
Member

dpogue commented Mar 9, 2026

This might need the same fix in the install path...

It might actually be better to fix this in cordova-common and ensure that all of the podspec values fall back to an empty array instead of being null/undefined: https://github.com/apache/cordova-common/blob/82c1b2f259f59423b3f59630142ea452cdf9be7a/src/PluginInfo/PluginInfo.js#L290-L298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants