-
Notifications
You must be signed in to change notification settings - Fork 689
[MySQL, Oracle] Parse optimizer hints #2162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@xitep wondering would it not make more sense to support features like these via the new |
|
surely it would be one way. (the only premise for that would to be have the next non-comment token after the corresponding keywords covered with a span, like suggested in #2099.) however, when processing such statements, these hints are something you generally don't want to leave out, even when parsing without comments. hence this proposal to embed it directly into the AST. |
76e9c41 to
800a4f3
Compare
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
20b7074 to
f80afd0
Compare
this should resolve #1995