Skip to content

Conversation

@heguanhui
Copy link
Contributor

@heguanhui heguanhui commented Feb 1, 2026

What problem does this PR solve?

Fix low wal disk test cast failure issues, test_low_wal_disk_space_fault_injection.groovy suite.
1.remove absent be debug point in this suite
2.correctly adding group commit in asynchronous mode, successfully downgrading due to insufficient disk space in wal
3.correctly add group commit and intercept due to insufficient disk space in wal mode when transitioning from asynchronous mode to sync mode

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 1, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@heguanhui
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31891 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

------ Round 1 ----------------------------------
q1	17617	5251	5077	5077
q2	2010	303	190	190
q3	10234	1292	762	762
q4	10224	896	320	320
q5	7559	2145	1964	1964
q6	197	184	150	150
q7	894	751	622	622
q8	9269	1404	1088	1088
q9	5170	4972	4837	4837
q10	6811	1950	1548	1548
q11	517	294	275	275
q12	336	387	232	232
q13	17822	4045	3223	3223
q14	231	236	219	219
q15	918	823	808	808
q16	680	690	612	612
q17	630	755	510	510
q18	6752	6527	6387	6387
q19	1244	984	605	605
q20	394	346	234	234
q21	2670	2068	1952	1952
q22	346	319	276	276
Total cold run time: 102525 ms
Total hot run time: 31891 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5314	5306	5335	5306
q2	260	339	253	253
q3	2173	2726	2275	2275
q4	1352	1721	1299	1299
q5	4327	4245	4424	4245
q6	210	180	142	142
q7	2219	2137	1857	1857
q8	2589	2497	2421	2421
q9	7542	7727	7489	7489
q10	2976	3185	2753	2753
q11	538	476	449	449
q12	717	820	620	620
q13	3826	4699	3480	3480
q14	300	311	290	290
q15	930	825	844	825
q16	676	728	684	684
q17	1133	1382	1384	1382
q18	8276	7665	8075	7665
q19	890	831	879	831
q20	2089	2189	2002	2002
q21	4838	4240	4012	4012
q22	592	552	500	500
Total cold run time: 53767 ms
Total hot run time: 50780 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.55 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.04	0.05
query3	0.25	0.08	0.09
query4	1.61	0.11	0.11
query5	0.26	0.24	0.25
query6	1.18	0.69	0.66
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.55	0.49	0.48
query10	0.56	0.56	0.54
query11	0.14	0.09	0.09
query12	0.14	0.10	0.10
query13	0.63	0.61	0.61
query14	1.08	1.06	1.07
query15	0.87	0.85	0.87
query16	0.38	0.43	0.39
query17	1.16	1.16	1.11
query18	0.23	0.21	0.21
query19	2.08	2.01	2.06
query20	0.02	0.01	0.02
query21	15.40	0.29	0.15
query22	5.24	0.05	0.04
query23	15.88	0.29	0.10
query24	1.50	0.57	0.52
query25	0.08	0.08	0.08
query26	0.14	0.13	0.14
query27	0.08	0.10	0.06
query28	4.78	1.13	0.96
query29	12.59	3.92	3.15
query30	0.28	0.13	0.11
query31	2.82	0.62	0.39
query32	3.24	0.60	0.50
query33	3.22	3.31	3.33
query34	16.00	5.41	4.70
query35	4.81	4.76	4.81
query36	0.64	0.49	0.49
query37	0.11	0.07	0.07
query38	0.07	0.04	0.03
query39	0.04	0.03	0.03
query40	0.19	0.16	0.16
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 98.68 s
Total hot run time: 28.55 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.52% (19287/36723)
Line Coverage 35.98% (179177/497960)
Region Coverage 32.39% (138969/429041)
Branch Coverage 33.34% (60133/180351)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.53% (25751/35998)
Line Coverage 54.18% (269149/496783)
Region Coverage 51.84% (224717/433451)
Branch Coverage 53.21% (96362/181083)

@heguanhui
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31445 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

------ Round 1 ----------------------------------
q1	17597	5173	5066	5066
q2	2033	306	195	195
q3	10183	1311	723	723
q4	10199	828	300	300
q5	7512	2163	1853	1853
q6	195	180	146	146
q7	894	740	599	599
q8	9254	1325	1041	1041
q9	5223	4834	4668	4668
q10	6755	1936	1574	1574
q11	487	307	280	280
q12	334	373	224	224
q13	17773	4071	3258	3258
q14	238	246	211	211
q15	888	810	821	810
q16	679	678	629	629
q17	640	760	520	520
q18	6724	6347	6378	6347
q19	1594	997	616	616
q20	402	346	231	231
q21	2599	2034	1882	1882
q22	349	311	272	272
Total cold run time: 102552 ms
Total hot run time: 31445 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5277	5271	5298	5271
q2	254	328	244	244
q3	2145	2698	2268	2268
q4	1323	1721	1275	1275
q5	4307	4181	4313	4181
q6	220	181	146	146
q7	1938	2291	1864	1864
q8	2590	2526	2548	2526
q9	7814	7610	7481	7481
q10	2750	3036	2703	2703
q11	564	472	450	450
q12	674	732	612	612
q13	3864	4435	3572	3572
q14	287	322	307	307
q15	899	820	826	820
q16	705	726	679	679
q17	1168	1320	1333	1320
q18	8180	7941	8161	7941
q19	864	821	835	821
q20	2065	2199	2016	2016
q21	4785	4491	4243	4243
q22	575	547	501	501
Total cold run time: 53248 ms
Total hot run time: 51241 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

query1	0.05	0.05	0.04
query2	0.10	0.05	0.05
query3	0.26	0.08	0.09
query4	1.60	0.11	0.11
query5	0.26	0.26	0.24
query6	1.16	0.68	0.67
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.56	0.51	0.50
query10	0.55	0.56	0.54
query11	0.14	0.09	0.09
query12	0.14	0.11	0.11
query13	0.63	0.61	0.64
query14	1.06	1.05	1.05
query15	0.88	0.86	0.88
query16	0.38	0.41	0.40
query17	1.13	1.12	1.12
query18	0.23	0.21	0.21
query19	2.11	1.98	2.02
query20	0.02	0.02	0.01
query21	15.39	0.23	0.15
query22	5.28	0.05	0.04
query23	16.01	0.30	0.10
query24	0.97	0.63	0.49
query25	0.11	0.08	0.08
query26	0.15	0.13	0.13
query27	0.07	0.07	0.06
query28	4.20	1.14	0.96
query29	12.56	3.87	3.12
query30	0.30	0.13	0.12
query31	2.82	0.63	0.40
query32	3.24	0.60	0.50
query33	3.18	3.17	3.26
query34	16.02	5.36	4.77
query35	4.80	4.79	4.81
query36	0.65	0.50	0.49
query37	0.11	0.07	0.06
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.19	0.16	0.15
query41	0.09	0.04	0.04
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 97.69 s
Total hot run time: 28.5 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.53% (19351/36838)
Line Coverage 36.00% (179681/499173)
Region Coverage 32.36% (139293/430469)
Branch Coverage 33.34% (60290/180842)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.51% (25741/35998)
Line Coverage 54.15% (268987/496783)
Region Coverage 51.80% (224522/433451)
Branch Coverage 53.17% (96285/181083)

@heguanhui
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34227 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

------ Round 1 ----------------------------------
q1	17614	5808	5652	5652
q2	2046	333	197	197
q3	10159	1439	787	787
q4	10253	978	323	323
q5	7575	2342	2053	2053
q6	222	196	151	151
q7	964	778	597	597
q8	9269	1565	1321	1321
q9	5443	4939	4998	4939
q10	6858	1998	1587	1587
q11	525	311	311	311
q12	343	406	232	232
q13	17770	4345	3226	3226
q14	246	241	225	225
q15	917	806	816	806
q16	666	721	606	606
q17	656	875	492	492
q18	6815	7262	7297	7262
q19	1359	1182	678	678
q20	443	384	250	250
q21	3227	2526	2248	2248
q22	408	322	284	284
Total cold run time: 103778 ms
Total hot run time: 34227 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6487	6520	6467	6467
q2	303	362	278	278
q3	2456	2987	2637	2637
q4	1545	1899	1400	1400
q5	4887	4805	4829	4805
q6	275	213	141	141
q7	2264	2024	1774	1774
q8	3054	2766	2708	2708
q9	7774	7739	7753	7739
q10	2993	3101	2675	2675
q11	620	475	485	475
q12	701	762	599	599
q13	3805	4237	3259	3259
q14	299	283	267	267
q15	856	783	789	783
q16	671	705	647	647
q17	1333	1553	1466	1466
q18	7600	7443	7312	7312
q19	939	830	866	830
q20	2030	2105	1893	1893
q21	4942	4406	4247	4247
q22	599	552	493	493
Total cold run time: 56433 ms
Total hot run time: 52895 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.08
query4	1.60	0.11	0.12
query5	0.29	0.26	0.26
query6	1.17	0.67	0.69
query7	0.03	0.02	0.03
query8	0.04	0.04	0.04
query9	0.56	0.50	0.50
query10	0.56	0.55	0.54
query11	0.14	0.10	0.10
query12	0.14	0.10	0.10
query13	0.63	0.61	0.62
query14	1.06	1.04	1.05
query15	0.88	0.87	0.88
query16	0.41	0.41	0.40
query17	1.10	1.09	1.15
query18	0.22	0.22	0.21
query19	2.00	1.99	2.02
query20	0.02	0.01	0.02
query21	15.42	0.23	0.14
query22	5.14	0.04	0.04
query23	16.06	0.28	0.11
query24	2.47	0.24	0.54
query25	0.12	0.10	0.07
query26	0.14	0.12	0.13
query27	0.11	0.06	0.06
query28	5.52	1.13	0.96
query29	12.56	3.81	3.12
query30	0.28	0.14	0.12
query31	2.82	0.64	0.41
query32	3.23	0.59	0.49
query33	3.26	3.20	3.25
query34	15.96	5.36	4.74
query35	4.88	4.79	4.74
query36	0.65	0.49	0.48
query37	0.11	0.07	0.06
query38	0.07	0.05	0.03
query39	0.04	0.03	0.03
query40	0.19	0.16	0.15
query41	0.08	0.03	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 100.48 s
Total hot run time: 28.14 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.53% (19351/36838)
Line Coverage 36.00% (179682/499173)
Region Coverage 32.38% (139372/430469)
Branch Coverage 33.34% (60299/180842)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.32% (25750/36103)
Line Coverage 53.78% (267806/497975)
Region Coverage 51.34% (223273/434862)
Branch Coverage 52.64% (95573/181568)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.34% (25755/36103)
Line Coverage 53.80% (267913/497975)
Region Coverage 51.36% (223343/434862)
Branch Coverage 52.68% (95651/181568)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.34% (25755/36103)
Line Coverage 53.80% (267913/497975)
Region Coverage 51.36% (223343/434862)
Branch Coverage 52.68% (95651/181568)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.11% (26395/36103)
Line Coverage 56.13% (279515/497975)
Region Coverage 53.93% (234502/434862)
Branch Coverage 55.49% (100756/181568)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.16% (26413/36103)
Line Coverage 56.16% (279673/497975)
Region Coverage 53.96% (234632/434862)
Branch Coverage 55.52% (100804/181568)

@heguanhui
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32347 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

------ Round 1 ----------------------------------
q1	17736	5350	5046	5046
q2	2170	299	190	190
q3	10240	1259	719	719
q4	10257	834	311	311
q5	7529	2143	1913	1913
q6	192	176	146	146
q7	881	730	591	591
q8	9324	1342	1103	1103
q9	5446	4757	4833	4757
q10	7066	1956	1544	1544
q11	584	288	267	267
q12	631	376	219	219
q13	17935	4009	3203	3203
q14	233	245	222	222
q15	903	825	819	819
q16	702	697	641	641
q17	647	823	457	457
q18	6953	6865	7219	6865
q19	1284	1052	693	693
q20	415	358	234	234
q21	3003	2276	2114	2114
q22	387	322	293	293
Total cold run time: 104518 ms
Total hot run time: 32347 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5440	5475	5427	5427
q2	267	376	279	279
q3	2488	2936	2568	2568
q4	1514	1848	1438	1438
q5	4621	4423	4447	4423
q6	220	186	137	137
q7	2034	1955	1845	1845
q8	2534	2415	2359	2359
q9	7371	7617	7547	7547
q10	2778	3009	2551	2551
q11	559	473	459	459
q12	674	801	583	583
q13	3957	4063	3235	3235
q14	276	283	258	258
q15	835	809	786	786
q16	624	691	635	635
q17	1062	1287	1319	1287
q18	7614	7092	7287	7092
q19	802	767	756	756
q20	1949	2034	1877	1877
q21	4557	4108	4060	4060
q22	572	554	491	491
Total cold run time: 52748 ms
Total hot run time: 50093 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.52 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee93777c99e640b399924776d49c36599ee9818d, data reload: false

query1	0.05	0.05	0.05
query2	0.13	0.05	0.05
query3	0.26	0.08	0.09
query4	1.63	0.11	0.11
query5	0.26	0.25	0.25
query6	1.16	0.69	0.68
query7	0.03	0.03	0.03
query8	0.05	0.05	0.04
query9	0.57	0.50	0.50
query10	0.56	0.54	0.55
query11	0.15	0.10	0.10
query12	0.14	0.10	0.10
query13	0.62	0.62	0.61
query14	1.07	1.07	1.06
query15	0.88	0.85	0.90
query16	0.38	0.39	0.41
query17	1.10	1.15	1.10
query18	0.23	0.21	0.21
query19	2.12	2.01	2.08
query20	0.02	0.01	0.02
query21	15.41	0.27	0.15
query22	5.13	0.05	0.05
query23	15.89	0.28	0.10
query24	1.92	0.49	0.51
query25	0.12	0.09	0.06
query26	0.14	0.13	0.14
query27	0.08	0.06	0.05
query28	4.54	1.14	0.97
query29	12.56	3.82	3.15
query30	0.27	0.14	0.11
query31	2.82	0.64	0.40
query32	3.25	0.60	0.51
query33	3.27	3.20	3.34
query34	16.48	5.41	4.68
query35	4.78	4.84	4.82
query36	0.65	0.50	0.49
query37	0.13	0.07	0.07
query38	0.07	0.04	0.04
query39	0.06	0.03	0.03
query40	0.19	0.16	0.15
query41	0.10	0.03	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 99.37 s
Total hot run time: 28.52 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.53% (19351/36838)
Line Coverage 36.00% (179702/499173)
Region Coverage 32.39% (139440/430469)
Branch Coverage 33.35% (60315/180842)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.16% (26413/36103)
Line Coverage 56.16% (279673/497975)
Region Coverage 53.95% (234603/434862)
Branch Coverage 55.52% (100811/181568)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.16% (26413/36103)
Line Coverage 56.16% (279673/497975)
Region Coverage 53.95% (234603/434862)
Branch Coverage 55.52% (100811/181568)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.42% (25783/36103)
Line Coverage 53.88% (268321/497975)
Region Coverage 51.46% (223797/434862)
Branch Coverage 52.79% (95849/181568)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.42% (25783/36103)
Line Coverage 53.88% (268321/497975)
Region Coverage 51.46% (223797/434862)
Branch Coverage 52.79% (95849/181568)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants