Skip to content

Conversation

@heguanhui
Copy link
Contributor

@heguanhui heguanhui commented Feb 1, 2026

What problem does this PR solve?

fix data lost in insert into values for group commit when failed to memory allocate
1.add retry when allocate memory fail
2.cancel when allocate memory fail to ensure atomicity

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@heguanhui heguanhui force-pushed the bugfix/fix-group-commit-data-lost-when-alloc-mem-fail branch from 5aa0488 to 4f33bd5 Compare February 1, 2026 18:51
@heguanhui
Copy link
Contributor Author

run buildall

@heguanhui heguanhui force-pushed the bugfix/fix-group-commit-data-lost-when-alloc-mem-fail branch from 4f33bd5 to c520c09 Compare February 1, 2026 18:57
@heguanhui heguanhui force-pushed the bugfix/fix-group-commit-data-lost-when-alloc-mem-fail branch from c520c09 to 5c12109 Compare February 1, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants