Open
Conversation
Contributor
|
I'd be conservative and would not yet force users to require Java 17 as runtime, esp. given that is not yet 100% supported by Hadoop. A backward-compatible approach, similar to that described in HADOOP-18887 might be better. What about?
This option seems to work (I tried it, but without exhaustive testing). |
Member
Author
|
Yes I agree with you @sebastian-nagel I'm not keen to force a JDK upgrade to 17 via this PR either. I'll augment the PR accordingly. Thanks for the review. |
Member
Author
|
I augmented the CI to accommodate the backward-compatible Java version strategy for Apache Nutch, similar to the approach described in HADOOP-18887.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for NUTCH-3145. It is quite an interesting issue as JUnit 6 requires Java 17. I am not convinced/sure that we want to orchestrate an upgrade from Java 11 --> 17 through a JUnit upgrade. I opened this ticket as a bit of an experiment. It also encouraged me to check in on NUTCH-2987 and perhaps more importantly the behemoth that is HADOOP-17177.
Any feedback or thoughts welcome. Thank you